Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request/Advice: Implementing Websocket version of OnGetCompletedOrderDetailsAsync for Kraken #681

Open
jdx-john opened this issue Oct 27, 2021 · 1 comment

Comments

@jdx-john
Copy link
Contributor

We already implement this REST API https://docs.kraken.com/rest/#operation/getTradeHistory through OnGetCompletedOrderDetailsAsync. Kraken also provide a WebSocket equivalent that notifies you of your own trades: https://docs.kraken.com/websockets/#message-ownTrades. This is not implemented. The raw code should be quite simple but I'm not sure on the design:

  • A similar Kraken websocket API openOrders is implemented via OnGetPositionsWebSocketAsync which seems odd
  • I don't know if other exchanges have an equivalent to ownTrades.

Is there an obvious signature to use for this? It's something I'd find useful (I think) so I'm keen to write it.

@vslee
Copy link
Collaborator

vslee commented Oct 27, 2021

Yes, it looks like the wrong method was implemented.

Kraken also provide a WebSocket equivalent that notifies you of your own trades: https://docs.kraken.com/websockets/#message-ownTrades. This is not implemented. The raw code should be quite simple but I'm not sure on the design:

Looks like ownTrades should be implemented in GetCompletedOrderDetailsWebSocketAsync(). Would that work for you?

  • A similar Kraken websocket API openOrders is implemented via OnGetPositionsWebSocketAsync which seems odd
  • I don't know if other exchanges have an equivalent to ownTrades.

Yes, it looks like the openOrders should be implemented in GetOrderDetailsWebSocketAsync() instead of OnGetPositionsWebSocketAsync()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants