Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OCR optional #240

Open
manthey opened this issue Nov 8, 2021 · 0 comments
Open

Make OCR optional #240

manthey opened this issue Nov 8, 2021 · 0 comments
Labels
low Lower priority

Comments

@manthey
Copy link
Contributor

manthey commented Nov 8, 2021

I'd like to make having the ocr library optional, as it adds some installation burden and we'd like to use the rest of this plugin in other projects. Specifically, make easyocr an extra_requires in setup.py (as [ocr]).

Perhaps we should also add a value to the girder.local.conf file that sets the state of whether the ocr job should be run on import IF that the setting in the conf file exists (otherwise it would leave the state of the run-on-import setting alone).

In the ideal, if easyocr isn't installed, we'd show a note that OCR is unavailable in the settings page and not show its buttons. This would try to import easyocr and flag if it isn't available.

@manthey manthey added the low Lower priority label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low Lower priority
Projects
None yet
Development

No branches or pull requests

1 participant