From cb5332b6265186212af4436dbd2bafea0ef24295 Mon Sep 17 00:00:00 2001 From: guanbinrui Date: Thu, 26 Jun 2025 14:51:50 +0800 Subject: [PATCH 1/3] chore: bump version to 2.34.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index ceb9252c705..91a66f0c220 100644 --- a/package.json +++ b/package.json @@ -7,7 +7,7 @@ "yarn": ">=999.0.0", "npm": ">=999.0.0" }, - "version": "2.33.3", + "version": "2.34.0", "private": true, "license": "AGPL-3.0-or-later", "scripts": { From f2d88f31bcdecdaaa9665f0afb0322be9deadebe Mon Sep 17 00:00:00 2001 From: Wukong Sun Date: Fri, 27 Jun 2025 19:22:44 +0800 Subject: [PATCH 2/3] fix(risk-warning): handle approve promise rejection --- packages/web3-providers/src/RiskWarning/index.ts | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/packages/web3-providers/src/RiskWarning/index.ts b/packages/web3-providers/src/RiskWarning/index.ts index 094952b8883..d32627f3185 100644 --- a/packages/web3-providers/src/RiskWarning/index.ts +++ b/packages/web3-providers/src/RiskWarning/index.ts @@ -8,12 +8,14 @@ const BASE_URL = BASE_URL_MAP[process.env.NODE_ENV] export class RiskWarning { static async approve(address: string, pluginID = '') { - await fetch(`${BASE_URL}/v1/risk_warning/confirm`, { - method: 'POST', - body: JSON.stringify({ - address, - plugin_id: pluginID, - }), - }) + try { + await fetch(`${BASE_URL}/v1/risk_warning/confirm`, { + method: 'POST', + body: JSON.stringify({ + address, + plugin_id: pluginID, + }), + }) + } catch {} } } From 9a76520f17c0fb3fcabebb2787c56eb6576d7ad1 Mon Sep 17 00:00:00 2001 From: Wukong Sun Date: Fri, 27 Jun 2025 19:32:40 +0800 Subject: [PATCH 3/3] fix: follow up reviews --- .../WalletRiskWarningModal/WalletRiskWarning.tsx | 9 ++++++--- packages/web3-providers/src/RiskWarning/index.ts | 16 +++++++--------- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/packages/shared/src/UI/modals/WalletRiskWarningModal/WalletRiskWarning.tsx b/packages/shared/src/UI/modals/WalletRiskWarningModal/WalletRiskWarning.tsx index eb7a51b1a55..506035abca0 100644 --- a/packages/shared/src/UI/modals/WalletRiskWarningModal/WalletRiskWarning.tsx +++ b/packages/shared/src/UI/modals/WalletRiskWarningModal/WalletRiskWarning.tsx @@ -82,10 +82,13 @@ export function WalletRiskWarning({ account, open, pluginID, onClose }: WalletRi return } await RiskWarning?.approve?.(account) - onClose() - } catch { - // do nothing + } catch (err) { + showSnackbar((err as Error).message, { + variant: 'error', + preventDuplicate: true, + }) } + onClose() }, [showSnackbar, account, onClose]) return ( diff --git a/packages/web3-providers/src/RiskWarning/index.ts b/packages/web3-providers/src/RiskWarning/index.ts index d32627f3185..094952b8883 100644 --- a/packages/web3-providers/src/RiskWarning/index.ts +++ b/packages/web3-providers/src/RiskWarning/index.ts @@ -8,14 +8,12 @@ const BASE_URL = BASE_URL_MAP[process.env.NODE_ENV] export class RiskWarning { static async approve(address: string, pluginID = '') { - try { - await fetch(`${BASE_URL}/v1/risk_warning/confirm`, { - method: 'POST', - body: JSON.stringify({ - address, - plugin_id: pluginID, - }), - }) - } catch {} + await fetch(`${BASE_URL}/v1/risk_warning/confirm`, { + method: 'POST', + body: JSON.stringify({ + address, + plugin_id: pluginID, + }), + }) } }