Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers not set on some requests #3

Open
ghost opened this issue Aug 1, 2017 · 1 comment
Open

Headers not set on some requests #3

ghost opened this issue Aug 1, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Aug 1, 2017

Note: I'm not sure if this is the right place to report this issue, as I haven't tested the Chrome version, but @WyohKnott disabled issues in his fork for the Firefox port and the AMO page links here for support.


It seems that headers are only set on document requests, and not other types of requests such as script. For example, I set X-Forwarded-For to 3.157.156.231 on nick.com and mtvnservices.com, but the page doesn't load correctly, possibly due to missing headers on the other requests.

@DingoEatingFuzz
Copy link
Owner

DingoEatingFuzz commented Aug 2, 2017

I took a few minutes to do some preliminary investigating and I believe the issue is with this line: https://github.com/DingoEatingFuzz/chrome-headers-middleman/blob/master/background.js#L8

Chrome (and probably Firefox) provides the type of web request, and right now headers middleman only intercepts main_frame ones.

I'm sure I had a reason for this, but it's lost to the sands of time at this point.

I recommend forking, experimenting, and reporting your findings. Did it work as expected? Were there unintended consequences?

If it worked well, we can merge it in. If there were side effects, we can consider options. For instance, having a set of web request types applicable per rule or ruleset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant