CI: enforce clippy -D warnings

[1nonlypiece]

Description

Deny warnings in contracts crate.

Requirements and context

• Efficient review

• Clear rollback / no production impact for CI-only tasks

• Must be secure, fully tested, and documented

• Should be efficient and easy to review for auditors and integrators

Suggested execution

1. Fork the repository and create a branch: git checkout -b ci/clippy
2. Implement the changes listed below
3. Open a draft PR early for design feedback

Implement

• Touch .github/workflows/*.yml or tarpaulin.toml as needed
• Document in README.md how to run locally

Tests and documentation

• Add or extend automated tests: cargo test, CI logs
• Add or update documentation: README.md
• Add Rustdoc (///) on public contract APIs where applicable (NatSpec-style)
• Validate stated security assumptions explicitly in PR description

Test and commit

1. Run the full contract test suite (e.g. cargo test, Soroban local sandbox if applicable)
2. Cover edge cases called out in this issue
3. Attach test output summary and short security notes in the PR
4. Ensure minimum 95% line coverage for touched modules (cargo tarpaulin / project standard)

Example commit message

chore(ci): clippy

Guidelines

Item	Target
Test coverage	≥ 95% on changed code
Documentation	Clear, versioned, matches on-chain behavior
Timeframe	96 hours from assignment

[drips-wave]

This issue has been added to the Stellar Wave Program and is worth 200 Points.

🧑‍💻 Interested in contributing? Apply to work on this issue on Drips Wave, earn points, and receive rewards.

Warning

Only applications submitted via the apply link above will be considered. Please do not apply by commenting on the issue or opening a PR directly.

🤠 Repo maintainers: You can manage this issue's Points and Complexity on your Maintainer Dashboard here. Please keep an eye on applications and respond quickly 💙

ℹ️ Learn more about Drips Wave

[kimcascante]

@kimcascante has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

Hello! I’m Kim Cascante, and I’d like to take this CI clippy enforcement issue.
I can update the CI workflows to enforce cargo clippy -- -D warnings for the contracts crate, ensuring all warnings are treated as errors. I’ll also document how to run clippy locally, update the README, and verify everything passes in CI with proper logs.
Additionally, I’ll run the full test suite, ensure high coverage on touched code, and include a clear PR description with testing results and security considerations for easy review.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @kimcascante to this issue.

[drips-wave]

Congratulations, @kimcascante! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on March 30, 2026.

🧑‍💻 @kimcascante: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been marked as completed by a Drips Wave moderator for @kimcascante as part of the Stellar Wave Program's 3rd Wave 🥳

Moderator's reason: [Auto-assessed] The contributor (kimcascante) successfully addressed the core requirements of issue #162 by updating the CI workflow and the contract's source to enforce clippy warnings as errors. PR #217 in Disciplr-Org/Disciplr-Contracts has been open for over 24 hours without any maintainer objections, meeting the criteria for approval.

😎 @kimcascante: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

ℹ️ Note: This issue was marked complete via moderation. Points were issued even though the GitHub issue remains open.