Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add photo feature #4

Open
2 of 3 tasks
Discostu36 opened this issue Aug 3, 2022 · 2 comments
Open
2 of 3 tasks

Add photo feature #4

Discostu36 opened this issue Aug 3, 2022 · 2 comments
Labels
core functionality Core features needed for v1.0
Milestone

Comments

@Discostu36
Copy link
Owner

Discostu36 commented Aug 3, 2022

Add photography feature. This is only the basic implementation without upload functionality.

  • Create button in the object modal (Add object modal #6) that triggers photo intent with choice between choosing from gallery and launching photo app
  • Decide where photos should be stored and if this should be handled differently when photo came from gallery or from photo app (see below)
  • Decide file naming scheme. (See below)
@Discostu36 Discostu36 added the core functionality Core features needed for v1.0 label Aug 3, 2022
@Discostu36 Discostu36 added this to the 0.2 milestone Aug 3, 2022
@Discostu36
Copy link
Owner Author

Discostu36 commented Aug 6, 2022

Internal file naming (before upload):

Internally, a combination of OSM object ID and timestamp should be used:

{OSM-type}-{OSM-ID}-{Date}-{Time}.jpg

For example:
w-220007671-20220815-123523.jpg

For the unusual case of more than one photo in the same second, a dash followed by number is added.

w-220007671-20220815-123523-1.jpg

Files that were not taken with the app but imported, get -import added at the end, because they will be handled differently after upload.

w-220007671-20220815-123523-import.jpg

@Discostu36
Copy link
Owner Author

Discostu36 commented Aug 6, 2022

Standard file handling:

Photos taken with the app or imported from gallery are stored in a subfolder of the app. After upload to Wikimedia Commons, photos taken with the app are renamed and moved to 0/DCIM/OSM_Photos. The copies of imported photos are deleted.

Later, there should be a possibility to configure that behaviour. (#13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core functionality Core features needed for v1.0
Projects
None yet
Development

No branches or pull requests

1 participant