Reverts #129

Merge pull request #486 from Distributive-Network/revert-129-Xmader/feat/npm-py

Author: Xmader

.github/workflows/test-and-publish.yaml

@@ -154,6 +154,7 @@ jobs:
           apt-get update -y
           apt-get install -y sudo libnss3-dev libssl-dev
           apt-get install -y git # required for `actions/checkout`
+          apt-get install -y nodejs npm # required for pminit to build
           apt-get install -y build-essential
           apt-get install -y strace # required to run JS tests
           DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends tzdata # tzdata may ask for user interaction if not explicitly installed here

README.md

@@ -74,6 +74,7 @@ Read this if you want to build a local version.
     - rust
     - python3.8 or later with header files (python3-dev)
     - spidermonkey latest from mozilla-central
+    - npm (nodejs)
     - [Poetry](https://python-poetry.org/docs/#installation)
     - [poetry-dynamic-versioning](https://github.com/mtkennerly/poetry-dynamic-versioning)
 

python/pminit/pmpm.py

@@ -1,13 +1,39 @@
-import os
-import pmpm
+import subprocess
+import sys
+import shutil
 
-WORK_DIR = os.path.join(
-  os.path.realpath(os.path.dirname(__file__)),
-  "pythonmonkey"
-)
+def execute(cmd: str):
+    popen = subprocess.Popen(cmd, stdout = subprocess.PIPE, stderr = subprocess.STDOUT,
+        shell = True, text = True )
+    for stdout_line in iter(popen.stdout.readline, ""):
+        sys.stdout.write(stdout_line)
+        sys.stdout.flush()
+
+    popen.stdout.close()
+    return_code = popen.wait()
+    if return_code:
+        raise subprocess.CalledProcessError(return_code, cmd)
 
 def main():
-  pmpm.main(WORK_DIR) # cd pythonmonkey && npm i
+    node_package_manager = 'npm'
+    # check if npm is installed on the system
+    if (shutil.which(node_package_manager) is None):
+        print("""
+
+PythonMonkey Build Error:
+
+    
+  *    It appears npm is not installed on this system.
+  *    npm is required for PythonMonkey to build.
+  *    Please install NPM and Node.js before installing PythonMonkey.
+  *    Refer to the documentation for installing NPM and Node.js here: https://nodejs.org/en/download
+
+
+        """)
+        raise Exception("PythonMonkey build error: Unable to find npm on the system.")
+    else:
+        execute(f"cd pythonmonkey && {node_package_manager} i --no-package-lock") # do not update package-lock.json
 
 if __name__ == "__main__":
-  main()
+    main()
+

python/pminit/post-install-hook.py

@@ -11,7 +11,6 @@ documentation = "https://docs.pythonmonkey.io/"
 repository = "https://github.com/Distributive-Network/PythonMonkey"
 
 include = [
-  "pmpm.py",
   # Install extra files into the pythonmonkey package
   "pythonmonkey/package*.json",
   { path = "pythonmonkey/node_modules/**/*", format = "wheel" },