Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Error Page #15

Closed
danieldanielecki opened this issue Apr 28, 2024 · 3 comments
Closed

[Feature] Error Page #15

danieldanielecki opened this issue Apr 28, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@danieldanielecki
Copy link
Member

Developer a proper Error Page view that would handle errors.

Since #13 the error handling is done on a basic level, so the page doesn't crash like initially in #3, but it doesn't look pretty at all.

The screenshot shows how it currently looks like for tests described in #3 (excl. PSPO, for which repo doesn't exists, and hence error on second screenshot is shown.
Screenshot 2024-04-28 at 12 52 35
Screenshot 2024-04-28 at 12 53 48

@danieldanielecki
Copy link
Member Author

Done, but error handling could've been improved across the app anyways.

@danieldanielecki
Copy link
Member Author

Done, but error handling could've been improved across the app anyways.

I meant: something on the root level of the application, to handle the second screenshot from this issue, when the entire app is done. Maybe something in the layout.tsx.

Error handling is done now for exam & practice tests, that's good, with nice UI. Also for search queries, in page.tsx, but something on the root level could've been added as well. Created #53 for improvement.

@danieldanielecki
Copy link
Member Author

In this issue UI has been improved, but still quite some to go with having the right mechanism to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant