css buttons show wrong text

[Zen4All]

When using css buttons in the admin, the buttons on the order detail page for adding a payment, refunding and purchase order, all show the text ADD.
So it is impossible to tell which button is which. Maybe some cssbutton functionality should be added. 😉

[rahul-96]

id them differently which might contain this particular info about the button.

[Zen4All]

After some sleep, and further inspection, I found the text is coming from a define. the basics of the button are fine.
I am going to investigate a code change, and make a PR later.

[DivaVocals]

While @lat9's Admin CSS buttons is a fantastic module, IMHO bundling in @lat9's CSS Admin button module is a bad idea for the same reason that is bundling ANY module with another is.. It requires the active maintainer to maintain BOTH or keep up with updates to the CSS Admin module and update Super Orders every time the other is updated.. That said I too stumbled upon the "bug" you refer to, and while I do not remember the solution, I acknowledge that there are some changes required to Super Orders to make it "more compatible" with the Admin CSS buttons module..

[Zen4All]

It was not my intention to incorporate the css module, that would as you said a bad idea.
The value is set in this function

  function button_add($payment_mode) {
    echo '&nbsp;<a href="javascript:popupWindow(\'' .
    zen_href_link(FILENAME_SUPER_PAYMENTS, 'oID=' . $this->oID . '&payment_mode=' . $payment_mode . '&action=add', 'NONSSL') . '\', \'scrollbars=yes,resizable=yes,width=400,height=300,screenX=150,screenY=100,top=100,left=150\')">' .
    zen_image_button('btn_' . $payment_mode . '.gif', sprintf(ALT_TEXT_ADD, str_replace('_', ' ', $payment_mode))) . '</a>';
  }

So we need to replace sprintf(ALT_TEXT_ADD with something smarter

[DivaVocals]

No worries my friend 😄.. Just trying to be CRYSTAL clear.. 😆

That said.. I MAY already have the solution.. I think I ran into this issue when installing the Admin CSS Buttons on my own site.. let me look at what I did to resolve the issue.. (it's been a bit.. 😸 )