Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the "REMAINDER_CHECK_INTERVAL" setting from the settings file to the settings application. #16

Open
2 of 6 tasks
DjangoCRM opened this issue Aug 6, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DjangoCRM
Copy link
Owner

DjangoCRM commented Aug 6, 2024

To make changing some project settings more convenient CRM has a Settings application that allows users to make changes through a web interface.

Here's what needs to be done:

  1. In settings app:
  • Create Reminders model with PositiveIntegerField (for the setting value).
  • In the admin.py file create RemindersAdmin in which the permissions to create and delete Reminders objects are set to False for all users.
  • Create a fixture with Reminders instance.
  1. In common app:
  • Add the loading of this fixture to the setupdata command.
  • In RemindersSender we change the receipt of the value "REMAINDER_CHECK_INTERVAL".
  • Create a test.

All changes must be committed separately (create a pull request), except for the last two points.
Every commit must pass existing tests.

Create draft pull requests to get assistance.

@DjangoCRM DjangoCRM added enhancement New feature or request good first issue Good for newcomers labels Aug 6, 2024
morganog added a commit to morganog/django-crm that referenced this issue Sep 4, 2024
DjangoCRM added a commit that referenced this issue Sep 4, 2024
ticket #16 Partial add to: reminders
@morganog
Copy link
Contributor

morganog commented Sep 6, 2024

I might try and do the instance, I haven't learned too much into how to do that. It might be good incentive to start learning though! That way you at least can have this knocked out on your issues.

@DjangoCRM
Copy link
Owner Author

Yes, you can find out about fixture here.
The project has examples in the fixtures directories.
Don't forget to run tests before pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants