-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cf names for all gsw functions #14
Comments
I'm not too sure about this one. The upstream gsw docs warn against using the sub modules so I'd rather not codify it here. The C version just has everything in alphabetical order by function name. There are not standard names for every gsw function either. Though there is a proposal process if we want to add new names. |
Ok, we can keep it alphabetical then. |
Your draft PR clarified what you meant by "wrap all functions" and I agree it is a good idea, especially to prevent pass through of attributes that would be incorrect for the output of some gsw function. Do you have ideas on how we should handle the situations where the inputs to the function can change or invalidate the standard name? (e.g. if the optional parameters of the z_from_p or p_from_z are not 0) |
Good question. I think that we could start by listing the number of "weird" functions, and depending on the number of them think about either 1) hardcode these special cases (if only a small number are problematic) or 2) find another solution. Another problem that will arise is that some functions (e.g. |
I made a test that would solve the issue that all functions don't produce the same number of attributes in PR #22 |
We should write the list of all functions and standard names attributes.
To keep the file
_cf_names.py
organized, we can maybe follow the gsw organization (i.e. splitting functions into density, ice, etc), e.g.The text was updated successfully, but these errors were encountered: