From 388df915678f16d6b959537ce8a7b7d91c4ab0c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Do=C4=9Fukan=20=C3=9Crker?= Date: Thu, 29 Jan 2026 02:39:45 +0300 Subject: [PATCH 1/6] Rename YAML config files to .yaml extension Renamed .yml files to .yaml for consistency across GitHub configuration and workflow files. Also added a .pre-commit-config.yaml for ruff pre-commit hooks. --- .github/{FUNDING.yml => FUNDING.yaml} | 0 .github/{dependabot.yml => dependabot.yaml} | 0 .github/workflows/{e2e-tests.yml => e2e-tests.yaml} | 2 +- .github/workflows/{ruff.yml => ruff.yaml} | 2 +- .pre-commit-config.yaml | 7 +++++++ 5 files changed, 9 insertions(+), 2 deletions(-) rename .github/{FUNDING.yml => FUNDING.yaml} (100%) rename .github/{dependabot.yml => dependabot.yaml} (100%) rename .github/workflows/{e2e-tests.yml => e2e-tests.yaml} (98%) rename .github/workflows/{ruff.yml => ruff.yaml} (98%) create mode 100644 .pre-commit-config.yaml diff --git a/.github/FUNDING.yml b/.github/FUNDING.yaml similarity index 100% rename from .github/FUNDING.yml rename to .github/FUNDING.yaml diff --git a/.github/dependabot.yml b/.github/dependabot.yaml similarity index 100% rename from .github/dependabot.yml rename to .github/dependabot.yaml diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yaml similarity index 98% rename from .github/workflows/e2e-tests.yml rename to .github/workflows/e2e-tests.yaml index 3e11245b0..6651fb247 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yaml @@ -1,4 +1,4 @@ -name: ๐Ÿงช E2E Tests +name: E2E Tests on: workflow_dispatch: diff --git a/.github/workflows/ruff.yml b/.github/workflows/ruff.yaml similarity index 98% rename from .github/workflows/ruff.yml rename to .github/workflows/ruff.yaml index 920ac071c..dddfbb5a4 100644 --- a/.github/workflows/ruff.yml +++ b/.github/workflows/ruff.yaml @@ -1,4 +1,4 @@ -name: ๐Ÿ Code Quality +name: Code Quality on: push: diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml new file mode 100644 index 000000000..97f261bb6 --- /dev/null +++ b/.pre-commit-config.yaml @@ -0,0 +1,7 @@ +repos: + - repo: https://github.com/astral-sh/ruff-pre-commit + rev: v0.14.8 + hooks: + - id: ruff-check + args: [--fix] + - id: ruff-format From 693c3d79a13c67c3b5e0efccd0260b751f1333c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Do=C4=9Fukan=20=C3=9Crker?= Date: Thu, 29 Jan 2026 02:41:24 +0300 Subject: [PATCH 2/6] Update test_logout.py --- tests/e2e/auth/test_logout.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/e2e/auth/test_logout.py b/tests/e2e/auth/test_logout.py index 7b6007fbb..9d13fdf52 100644 --- a/tests/e2e/auth/test_logout.py +++ b/tests/e2e/auth/test_logout.py @@ -251,7 +251,8 @@ def test_logout_and_login_as_different_user( # Login as test user login_page.navigate("/login/redirect=&") login_page.login(test_user.username, test_user.password) - page.wait_for_url("**/", timeout=5000) + page.wait_for_load_state("networkidle") + page.wait_for_url("**/", timeout=10000) # Verify logged in as different user navbar.expect_logged_in() From 17a6965bad23a53b8ad2777d913ca9125ea3fffc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Do=C4=9Fukan=20=C3=9Crker?= Date: Thu, 29 Jan 2026 02:42:05 +0300 Subject: [PATCH 3/6] Standardize workflow naming and step labels Renamed ruff.yaml to code-quality.yaml and updated all workflow and step names to use lowercase for consistency. Applied similar lowercase naming conventions to e2e-tests.yaml, including step names and input descriptions. --- .../{ruff.yaml => code-quality.yaml} | 22 +++++++++---------- .github/workflows/e2e-tests.yaml | 14 ++++++------ 2 files changed, 18 insertions(+), 18 deletions(-) rename .github/workflows/{ruff.yaml => code-quality.yaml} (74%) diff --git a/.github/workflows/ruff.yaml b/.github/workflows/code-quality.yaml similarity index 74% rename from .github/workflows/ruff.yaml rename to .github/workflows/code-quality.yaml index dddfbb5a4..d959cb31a 100644 --- a/.github/workflows/ruff.yaml +++ b/.github/workflows/code-quality.yaml @@ -1,4 +1,4 @@ -name: Code Quality +name: code quality on: push: @@ -20,7 +20,7 @@ concurrency: jobs: ruff-check: - name: ๐Ÿ” Lint & Format Check + name: lint & format check runs-on: ubuntu-latest timeout-minutes: 10 strategy: @@ -28,15 +28,15 @@ jobs: python-version: ["3.13"] steps: - - name: ๐Ÿ“ฅ Checkout repository + - name: checkout repository uses: actions/checkout@v4 - - name: ๐Ÿ Set up Python ${{ matrix.python-version }} + - name: set up python ${{ matrix.python-version }} uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} - - name: ๐Ÿ’พ Cache pip dependencies + - name: cache pip dependencies uses: actions/cache@v4 with: path: ~/.cache/pip @@ -45,24 +45,24 @@ jobs: ${{ runner.os }}-pip-${{ matrix.python-version }}- ${{ runner.os }}-pip- - - name: ๐Ÿ“ฆ Install Ruff + - name: install ruff run: | python -m pip install --upgrade pip pip install ruff - - name: โœจ Check code formatting + - name: check code formatting run: | ruff format --check --diff . - - name: ๐Ÿ” Lint code + - name: lint code run: | ruff check --output-format=github . - - name: ๐Ÿ“Š Generate Ruff report + - name: generate ruff report if: failure() run: | - echo "## ๐Ÿ Ruff Issues Found" >> $GITHUB_STEP_SUMMARY - echo "The following issues were found by Ruff:" >> $GITHUB_STEP_SUMMARY + echo "## ruff issues found" >> $GITHUB_STEP_SUMMARY + echo "the following issues were found by ruff:" >> $GITHUB_STEP_SUMMARY echo '```' >> $GITHUB_STEP_SUMMARY ruff check --output-format=text . >> $GITHUB_STEP_SUMMARY || true echo '```' >> $GITHUB_STEP_SUMMARY diff --git a/.github/workflows/e2e-tests.yaml b/.github/workflows/e2e-tests.yaml index 6651fb247..aa8a1f6ea 100644 --- a/.github/workflows/e2e-tests.yaml +++ b/.github/workflows/e2e-tests.yaml @@ -1,10 +1,10 @@ -name: E2E Tests +name: e2e tests on: workflow_dispatch: inputs: test_path: - description: "Specific test to run (e.g., e2e/auth/test_login.py::TestLoginSuccess)" + description: "specific test to run (e.g., e2e/auth/test_login.py::TestLoginSuccess)" required: false default: "e2e/" push: @@ -30,27 +30,27 @@ jobs: timeout-minutes: 15 steps: - - name: Checkout repository + - name: checkout repository uses: actions/checkout@v4 - - name: Set up Python 3.13 + - name: set up python 3.13 uses: actions/setup-python@v5 with: python-version: "3.13" - - name: Install uv + - name: install uv uses: astral-sh/setup-uv@v4 with: enable-cache: true cache-dependency-glob: "app/pyproject.toml" - - name: Install dependencies + - name: install dependencies run: | cd app uv sync --extra test uv run playwright install chromium --with-deps - - name: Run E2E tests + - name: run e2e tests run: | cd app uv run pytest ../tests/${{ github.event.inputs.test_path || 'e2e/' }} -v --tb=short From 291cc56f6778dcc0fdd639fb9db42d38f9c10cd2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Do=C4=9Fukan=20=C3=9Crker?= Date: Thu, 29 Jan 2026 02:42:18 +0300 Subject: [PATCH 4/6] Standardize workflow names in GitHub Actions Renamed workflow names in code-quality.yaml and e2e-tests.yaml to use hyphens for consistency with file names and naming conventions. --- .github/workflows/code-quality.yaml | 2 +- .github/workflows/e2e-tests.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/code-quality.yaml b/.github/workflows/code-quality.yaml index d959cb31a..d0081470e 100644 --- a/.github/workflows/code-quality.yaml +++ b/.github/workflows/code-quality.yaml @@ -1,4 +1,4 @@ -name: code quality +name: code-quality on: push: diff --git a/.github/workflows/e2e-tests.yaml b/.github/workflows/e2e-tests.yaml index aa8a1f6ea..eaecdf562 100644 --- a/.github/workflows/e2e-tests.yaml +++ b/.github/workflows/e2e-tests.yaml @@ -1,4 +1,4 @@ -name: e2e tests +name: e2e-tests on: workflow_dispatch: From 4d7a285a2d4d74729596ce6d0d03c818f6183540 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Do=C4=9Fukan=20=C3=9Crker?= Date: Thu, 29 Jan 2026 02:46:01 +0300 Subject: [PATCH 5/6] Update test_logout.py --- tests/e2e/auth/test_logout.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/e2e/auth/test_logout.py b/tests/e2e/auth/test_logout.py index 9d13fdf52..84b2c5495 100644 --- a/tests/e2e/auth/test_logout.py +++ b/tests/e2e/auth/test_logout.py @@ -2,7 +2,10 @@ E2E tests for the logout functionality. """ +import re + import pytest +from playwright.sync_api import expect from tests.e2e.pages.base_page import BasePage from tests.e2e.pages.login_page import LoginPage @@ -252,7 +255,10 @@ def test_logout_and_login_as_different_user( login_page.navigate("/login/redirect=&") login_page.login(test_user.username, test_user.password) page.wait_for_load_state("networkidle") - page.wait_for_url("**/", timeout=10000) + # Use regex to match home URL with or without trailing slash + expect(page).to_have_url( + re.compile(rf"^{re.escape(flask_server['base_url'])}/?$"), timeout=10000 + ) # Verify logged in as different user navbar.expect_logged_in() From b50a612fcb5f5a2ea737e96e33a75feb13e4b251 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Do=C4=9Fukan=20=C3=9Crker?= Date: Thu, 29 Jan 2026 02:49:09 +0300 Subject: [PATCH 6/6] Update GitHub workflows to use latest actions and Python 3.14 Updated code-quality and e2e-tests workflows to use Python 3.14, latest versions of GitHub Actions (checkout, setup-python, cache, setup-uv), and corrected workflow file extensions from .yml to .yaml in path filters. This ensures compatibility with the latest tools and maintains consistency in workflow configuration. --- .github/workflows/code-quality.yaml | 12 ++++++------ .github/workflows/e2e-tests.yaml | 14 +++++++------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/code-quality.yaml b/.github/workflows/code-quality.yaml index d0081470e..f8b270587 100644 --- a/.github/workflows/code-quality.yaml +++ b/.github/workflows/code-quality.yaml @@ -6,13 +6,13 @@ on: paths: - "**.py" - "app/pyproject.toml" - - ".github/workflows/ruff.yml" + - ".github/workflows/ruff.yaml" pull_request: branches: [main] paths: - "**.py" - "app/pyproject.toml" - - ".github/workflows/ruff.yml" + - ".github/workflows/ruff.yaml" concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -25,19 +25,19 @@ jobs: timeout-minutes: 10 strategy: matrix: - python-version: ["3.13"] + python-version: ["3.14"] steps: - name: checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@v6 - name: set up python ${{ matrix.python-version }} - uses: actions/setup-python@v5 + uses: actions/setup-python@v6 with: python-version: ${{ matrix.python-version }} - name: cache pip dependencies - uses: actions/cache@v4 + uses: actions/cache@v5 with: path: ~/.cache/pip key: ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ hashFiles('**/requirements*.txt', '**/pyproject.toml') }} diff --git a/.github/workflows/e2e-tests.yaml b/.github/workflows/e2e-tests.yaml index eaecdf562..20a8b92ab 100644 --- a/.github/workflows/e2e-tests.yaml +++ b/.github/workflows/e2e-tests.yaml @@ -12,13 +12,13 @@ on: paths: - "app/**" - "tests/**" - - ".github/workflows/e2e-tests.yml" + - ".github/workflows/e2e-tests.yaml" pull_request: branches: [main] paths: - "app/**" - "tests/**" - - ".github/workflows/e2e-tests.yml" + - ".github/workflows/e2e-tests.yaml" concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -31,15 +31,15 @@ jobs: steps: - name: checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@v6 - - name: set up python 3.13 - uses: actions/setup-python@v5 + - name: set up python 3.14 + uses: actions/setup-python@v6 with: - python-version: "3.13" + python-version: "3.14" - name: install uv - uses: astral-sh/setup-uv@v4 + uses: astral-sh/setup-uv@v7 with: enable-cache: true cache-dependency-glob: "app/pyproject.toml"