Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execBackground to notify user of webpack build errors #337

Closed
1 of 2 tasks
Domiii opened this issue Sep 28, 2020 · 1 comment
Closed
1 of 2 tasks

Fix execBackground to notify user of webpack build errors #337

Domiii opened this issue Sep 28, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Domiii
Copy link
Owner

Domiii commented Sep 28, 2020

  • Notify user of build errors/warnings
    • maybe need to give Webpack some sort of error handler in Watch mode?

Done

  • [bug] startWatchMode progress indicator gets stuck forever, if Webpack or Rollup fail on startup: make sure, to stop waiting if process error'ed or exited
    • NOTE: This fixes the problem if there are crucial problems initially
@Domiii Domiii added enhancement New feature or request priority labels Sep 28, 2020
@Domiii Domiii added this to the Eslint ready milestone Sep 28, 2020
@Domiii Domiii self-assigned this Sep 28, 2020
@Domiii Domiii removed the priority label Oct 15, 2020
@Domiii Domiii removed this from the Eslint ready milestone Apr 10, 2021
@Domiii Domiii changed the title Fix execBackground to handle webpack errors properly Fix execBackground to notify user of webpack build errors May 7, 2021
@Domiii
Copy link
Owner Author

Domiii commented Dec 3, 2021

Merged into #615

@Domiii Domiii closed this as completed Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant