Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set a matching tag when setting an item's read status #39

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Dominic-DallOsto
Copy link
Owner

@Dominic-DallOsto Dominic-DallOsto commented Jul 27, 2024

Fixes #8

  • Automatically set a tag matching an item's read status
  • Update tags to match read status (when enabling the feature)
  • Update read status to match tags
    • trigger this when loading library after changing tags on app or on sync

What happens when adding custom read statuses?

Copy link

🚀 This ticket has been resolved in v1.4.0-beta. See Release 1.4.0-beta for release notes.

@Dominic-DallOsto Dominic-DallOsto force-pushed the read-status-tags branch 2 times, most recently from a52a919 to addd493 Compare August 8, 2024 15:19
Copy link

github-actions bot commented Aug 8, 2024

🚀 This ticket has been resolved in v1.6.0-beta.0. See Release 1.6.0-beta.0 for release notes.

@MaxVonMustermann
Copy link

MaxVonMustermann commented Aug 20, 2024

I tested beta version 1.60-beta0 and the foundation is there now! Great work. One additional idea: Read status regarding columns features an emoji-only mode, text+emoji or only text. Since tags also support emojis, this functionality would be highly appreciated, if added to tags as well (especially an "emoji-only" setting). Thank you!

@Dominic-DallOsto
Copy link
Owner Author

I tested beta version 1.60-beta0 and the foundation is there now! Great work. One additional idea: Read status regarding columns features an emoji-only mode, text+emoji or only text. Since tags also support emojis, this functionality would be highly appreciated, if added to tags as well (especially an "emoji-only" setting). Thank you!

Ahh, does applying a tag with an emoji also cause the emoji to appear in front of the item's title on the app, like it does in desktop Zotero?

@MaxVonMustermann
Copy link

I tested beta version 1.60-beta0 and the foundation is there now! Great work. One additional idea: Read status regarding columns features an emoji-only mode, text+emoji or only text. Since tags also support emojis, this functionality would be highly appreciated, if added to tags as well (especially an "emoji-only" setting). Thank you!

Ahh, does applying a tag with an emoji also cause the emoji to appear in front of the item's title on the app, like it does in desktop Zotero?

Yes, it does.

Copy link

github-actions bot commented Sep 5, 2024

🚀 This ticket has been resolved in v1.6.0-beta.1. See Release 1.6.0-beta.1 for release notes.

@Dominic-DallOsto
Copy link
Owner Author

@MaxVonMustermann I added the option of including emojis in tags in the latest beta, so you can see the read status emojis in front of the items titles. See what you think!

I didn't add an option to only use emojis and no text for the tags because we don't enforce that there's a unique emoji for each read status, so it might not be possible to uniquely determine the read status from just the emoji. I think I'd prefer to leave it like this, so users have the flexibility to have two read statuses with the same emoji if they want, unless you have a strong use case for emoji-only tags?

@MaxVonMustermann
Copy link

MaxVonMustermann commented Sep 5, 2024

@MaxVonMustermann I added the option of including emojis in tags in the latest beta, so you can see the read status emojis in front of the items titles. See what you think!

I didn't add an option to only use emojis and no text for the tags because we don't enforce that there's a unique emoji for each read status, so it might not be possible to uniquely determine the read status from just the emoji. I think I'd prefer to leave it like this, so users have the flexibility to have two read statuses with the same emoji if they want, unless you have a strong use case for emoji-only tags?

Thank you, it works well! I assume this is a limitation from Zotero's side that adding emojis to tags will cause emojis to always appear in the title of the parent file?
This is, nevertheless, not too bad, since you can hide the dedicated read status column to prevent wasting space.
I see your point regarding "emoji only" tags.

Edit: having the emojis in front of the title is aboslutely fantastic for iOS use cases. It's like having the plugin installed on iOS, with the reading status being visible there as well. Brilliant job!!

@Dominic-DallOsto
Copy link
Owner Author

Dominic-DallOsto commented Sep 5, 2024

Yeah, I don't think it's possible to disable showing the emojis in front of the item titles. (edit: it might work by overwriting this function to always return false - https://github.com/zotero/zotero/blob/4c04dc583e3b74f4dcb7fdf50ae46f6c17c1a3a3/chrome/content/zotero/xpcom/utilities_internal.js#L399 - but I'd have to check if that won't have unintended consequences for anywhere else it's used)

But good to hear it works nicely on iOS! Thanks for testing!

Actually, does it work for you to not use icons at all, but to make the status names emojis instead of text? That might work as a workaround to have emoji only tags?

@MaxVonMustermann
Copy link

Yeah, I don't think it's possible to disable showing the emojis in front of the item titles.

But good to hear it works nicely on iOS! Thanks for testing!

Actually, does it work for you to not use emojis at all, but the make the status names emojis instead of text? That might work as a workaround to have emoji only tags?

You're welcome.
Well, it works with a limitation. The "emoji-only" tag is shown in front of the name and on the iPad as well. On the iPad, it is also shown in the tag list, which isn't the case on the Mac app. There, the limitation is that the "emoji-only" tag does not appear in the tag list (left pane) at all.

@Dominic-DallOsto
Copy link
Owner Author

Dominic-DallOsto commented Sep 5, 2024

Hmm, it works for me on Windows, but I had to manually update all the item's read statuses from their text to their emoji versions

image

But yeah, this will still show the emoji in front of the title because I think Zotero does this whenever there's an emoji in the tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants