Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket ID "lingering" #18

Open
wavexx opened this issue Dec 16, 2014 · 0 comments
Open

Ticket ID "lingering" #18

wavexx opened this issue Dec 16, 2014 · 0 comments

Comments

@wavexx
Copy link
Member

wavexx commented Dec 16, 2014

Ticket IDs are currently guaranteed to be unique, but nothing prevents that a new ID reuses an ID that existed just 2 seconds ago[*]. In this scenario, an user clicking on an expired link would receive the content of a new file instead.

[*] this is currently unlikely due to how the ID is generated, but possible nonetheless.

We should store ticket IDs on a new table upon expiration, for a much longer period (1 year or so), to avoid re-use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant