Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dedicated Health Check assembly and/or NuGet package #122

Open
KrzysFR opened this issue May 29, 2023 · 1 comment
Open

Add a dedicated Health Check assembly and/or NuGet package #122

KrzysFR opened this issue May 29, 2023 · 1 comment
Labels
api Issues or changes related to the client API enhancement

Comments

@KrzysFR
Copy link
Member

KrzysFR commented May 29, 2023

Looking at https://learn.microsoft.com/en-us/aspnet/core/host-and-deploy/health-checks?view=aspnetcore-7.0#distribute-a-health-check-library it is possible to write a health check for ASP.NET Core that comes as a library.

We should add a FoundationDBHealthCheck class that implements IHealthCheck.

This class could either be redistributed via its own assembly/package, OR could be part of the already existing FoundationDB.Client.DependencyInjection assembly ?

@KrzysFR KrzysFR added enhancement api Issues or changes related to the client API labels May 29, 2023
@KrzysFR
Copy link
Member Author

KrzysFR commented Dec 15, 2023

The health check is included as part of the Aspire component work, see #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues or changes related to the client API enhancement
Projects
None yet
Development

No branches or pull requests

1 participant