Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up BlockBuilder #28

Open
DrChainsaw opened this issue Aug 17, 2018 · 0 comments
Open

Clean up BlockBuilder #28

DrChainsaw opened this issue Aug 17, 2018 · 0 comments

Comments

@DrChainsaw
Copy link
Owner

The internal builders of this class are very similar to each other and can hopefully be generalized into fewer more generic types.

The main thing in which they differ is that they each have a unique LayerBlockConfig is to be composed of other LayerBlockConfigs (through the builders methods).

If "composable" LayerBlockConfigs implement some common API (or are wrapped in one) then it should be possible to reduce the number of internal builders significantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant