Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistantly getting a python code error. #14

Closed
Hime0698 opened this issue Apr 16, 2024 · 4 comments
Closed

Consistantly getting a python code error. #14

Hime0698 opened this issue Apr 16, 2024 · 4 comments

Comments

@Hime0698
Copy link

CleanShot 2024-04-16 at 11 48 57@2x
I am consistently getting this error on various different games when I try to download my whole library.

Is there any fix to this, or a way to bypass the error and download everything but the erroring ones?

@TheFrenchGhosty
Copy link

@Hime0698 Just run the script on a loop, it starts from a different "position" everytime so if you run it often enough, everything but the impossible-to-download files will be downloaded

@DragoonAethis
Copy link
Owner

Okay, looks like this is an issue with all access restricted pages. I've fixed the crash in 0.4.1, but restricted titles can't be downloaded for now. The rest of the library/bundle should go through normally. See #16 for a tracker on that. Thanks for your report!

@TheFrenchGhosty
Copy link

TheFrenchGhosty commented Apr 17, 2024

@DragoonAethis works exactly how it should, thanks

- Game data fetching failed for https://beowulf.itch.io/rpg-boss-monsters-minions-huge-pack (likely access restricted, see issue #16): ['invalid game']
- Game data fetching failed for https://world-land-trust.itch.io/thank-you-from-the-world-land-trust (likely access restricted, see issue #16): ['invalid game']
- Game data fetching failed for https://jayskibean.itch.io/microhorrorarcade-trilogy-i (likely access restricted, see issue #16): ['invalid game']

(Taken from the full log)

Though it seems to have missed https://witpop.itch.io/sprite-pack-fantasy-male-mage ? At least it doesn't crash though, it just 404

Download failed for https://witpop.itch.io/sprite-pack-fantasy-male-mage:
- Could not download the game site for https://witpop.itch.io/sprite-pack-fantasy-male-mage: 404 Client Error: Not Found for url: https://witpop.itch.io/sprite-pack-fantasy-male-mage

@DragoonAethis
Copy link
Owner

Yeah, I still need to detect restricted pages properly by looking at the page contents :/ For password-protected pages, itch returns HTTP 200 + error in JSON, but just HTTP 404 for plain restricted pages. Either way, I need to figure out a better way to scrape these pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants