Question regarding to update match game

[yongshun950824]

Here is the input Tournament data:

Sample Tournament Data

{
    "participant": [
        {
            "id": 0,
            "tournament_id": 6,
            "name": "Team 5"
        },
        {
            "id": 1,
            "tournament_id": 6,
            "name": "Team 6"
        },
        {
            "id": 2,
            "tournament_id": 6,
            "name": "Team 7"
        },
        {
            "id": 3,
            "tournament_id": 6,
            "name": "Team 8"
        }
    ],
    "stage": [
        {
            "id": 0,
            "tournament_id": 6,
            "name": "Random D9-3",
            "type": "double_elimination",
            "number": 9,
            "settings": {
                "size": 4,
                "seedOrdering": [
                    "inner_outer",
                    "natural"
                ],
                "grandFinal": "single",
                "matchesChildCount": 3,
                "groupCount": null,
                "roundRobinMode": null,
                "skipFirstRound": false
            }
        }
    ],
    "group": [
        {
            "id": 0,
            "stage_id": 0,
            "number": 1
        },
        {
            "id": 1,
            "stage_id": 0,
            "number": 2
        },
        {
            "id": 2,
            "stage_id": 0,
            "number": 3
        }
    ],
    "round": [
        {
            "id": 0,
            "number": 1,
            "stage_id": 0,
            "group_id": 0
        },
        {
            "id": 1,
            "number": 2,
            "stage_id": 0,
            "group_id": 0
        },
        {
            "id": 2,
            "number": 1,
            "stage_id": 0,
            "group_id": 1
        },
        {
            "id": 3,
            "number": 2,
            "stage_id": 0,
            "group_id": 1
        },
        {
            "id": 4,
            "number": 1,
            "stage_id": 0,
            "group_id": 2
        }
    ],
    "match": [
        {
            "id": 0,
            "number": 1,
            "stage_id": 0,
            "group_id": 0,
            "round_id": 0,
            "child_count": 3,
            "status": 2,
            "opponent1": {
                "id": 0,
                "position": 1
            },
            "opponent2": {
                "id": 3,
                "position": 4
            }
        },
        {
            "id": 1,
            "number": 2,
            "stage_id": 0,
            "group_id": 0,
            "round_id": 0,
            "child_count": 3,
            "status": 2,
            "opponent1": {
                "id": 1,
                "position": 2
            },
            "opponent2": {
                "id": 2,
                "position": 3
            }
        },
        {
            "id": 2,
            "number": 1,
            "stage_id": 0,
            "group_id": 0,
            "round_id": 1,
            "child_count": 3,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 3,
            "number": 1,
            "stage_id": 0,
            "group_id": 1,
            "round_id": 2,
            "child_count": 3,
            "status": 0,
            "opponent1": {
                "id": null,
                "position": 1
            },
            "opponent2": {
                "id": null,
                "position": 2
            }
        },
        {
            "id": 4,
            "number": 1,
            "stage_id": 0,
            "group_id": 1,
            "round_id": 3,
            "child_count": 3,
            "status": 0,
            "opponent1": {
                "id": null,
                "position": 1
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 5,
            "number": 1,
            "stage_id": 0,
            "group_id": 2,
            "round_id": 4,
            "child_count": 3,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null,
                "position": 1
            }
        }
    ],
    "match_game": [
        {
            "id": 0,
            "stage_id": 0,
            "parent_id": 0,
            "number": 1,
            "status": 2,
            "opponent1": {
                "id": 0
            },
            "opponent2": {
                "id": 3
            }
        },
        {
            "id": 1,
            "stage_id": 0,
            "parent_id": 0,
            "number": 2,
            "status": 2,
            "opponent1": {
                "id": 0
            },
            "opponent2": {
                "id": 3
            }
        },
        {
            "id": 2,
            "stage_id": 0,
            "parent_id": 0,
            "number": 3,
            "status": 2,
            "opponent1": {
                "id": 0
            },
            "opponent2": {
                "id": 3
            }
        },
        {
            "id": 3,
            "stage_id": 0,
            "parent_id": 1,
            "number": 1,
            "status": 2,
            "opponent1": {
                "id": 1
            },
            "opponent2": {
                "id": 2
            }
        },
        {
            "id": 4,
            "stage_id": 0,
            "parent_id": 1,
            "number": 2,
            "status": 2,
            "opponent1": {
                "id": 1
            },
            "opponent2": {
                "id": 2
            }
        },
        {
            "id": 5,
            "stage_id": 0,
            "parent_id": 1,
            "number": 3,
            "status": 2,
            "opponent1": {
                "id": 1
            },
            "opponent2": {
                "id": 2
            }
        },
        {
            "id": 6,
            "stage_id": 0,
            "parent_id": 2,
            "number": 1,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 7,
            "stage_id": 0,
            "parent_id": 2,
            "number": 2,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 8,
            "stage_id": 0,
            "parent_id": 2,
            "number": 3,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 9,
            "stage_id": 0,
            "parent_id": 3,
            "number": 1,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 10,
            "stage_id": 0,
            "parent_id": 3,
            "number": 2,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 11,
            "stage_id": 0,
            "parent_id": 3,
            "number": 3,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 12,
            "stage_id": 0,
            "parent_id": 4,
            "number": 1,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 13,
            "stage_id": 0,
            "parent_id": 4,
            "number": 2,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 14,
            "stage_id": 0,
            "parent_id": 4,
            "number": 3,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 15,
            "stage_id": 0,
            "parent_id": 5,
            "number": 1,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 16,
            "stage_id": 0,
            "parent_id": 5,
            "number": 2,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        },
        {
            "id": 17,
            "stage_id": 0,
            "parent_id": 5,
            "number": 3,
            "status": 0,
            "opponent1": {
                "id": null
            },
            "opponent2": {
                "id": null
            }
        }
    ]
}

In summary, each match consists of 3 match games.

I'm tried to update the match game as below:

First Update

await window.bracketsManager.update.matchGame({ parent_id: 0, id: 0, opponent1: { result: "win" }, opponent2: { result: "loss" } });

Initial with the line above, it updates successfully for the match data. (Getting the data via window.inMemoryDatabase.data)

Match (after First Update):

[
    {
        "id": 0,
        "number": 1,
        "stage_id": 0,
        "group_id": 0,
        "round_id": 0,
        "child_count": 3,
        "status": 3,
        "opponent1": {
            "id": 0,
            "position": 1,
            "score": 1
        },
        "opponent2": {
            "id": 3,
            "position": 4,
            "score": 0
        }
    }
]

Match Game (after First Update):

{
    "id": 0,
    "stage_id": 0,
    "parent_id": 0,
    "number": 1,
    "status": 4,
    "opponent1": {
        "id": 0
    },
    "opponent2": {
        "id": 3
    }
}

---

However, when I tried to re-update the same match game as below:

Second Update

await window.bracketsManager.update.matchGame({ parent_id: 0, id: 0, opponent1: { result: "loss" }, opponent2: { result: "win" } });

Match (after Second Update):

{
    "id": 0,
    "number": 1,
    "stage_id": 0,
    "group_id": 0,
    "round_id": 0,
    "child_count": 3,
    "status": 4,
    "opponent1": {
        "id": 0,
        "position": 1,
        "score": 0,
        "result": "loss"
    },
    "opponent2": {
        "id": 3,
        "position": 4,
        "score": 3,
        "result": "win"
    }
}

Match Game (after Second Update):

{
    "id": 0,
    "stage_id": 0,
    "parent_id": 0,
    "number": 1,
    "status": 4,
    "opponent1": {
        "id": 0
    },
    "opponent2": {
        "id": 3
    }
}

The match should be with the result:

Expected result: Status: 3 (Running), Opponent1: { Score: 0, Result: "loss" }, Opponent2: { Score: 1, Result: "win" }
Actual result: Status: 4 (Completed), Opponent1: { Score: 0, Result: "loss" }, Opponent2: { Score: 3, Result: "win" }

Think the update for the parent match is failed.

And also I think when after the First Update submission (which leads to match status: 3), when I update the match game, it leads the match result calculate wrongly.

It's hard to explain in words, so I upload the sample videos:

DEMO - Google Chrome 2022-03-24 22-37-10.zip

For code wise, when the button is clicked, I will prepare those match games to be updated and next executed:

// Logic prepare matchGames to be updated
let matchGamesToBeUpdated = [{ parent_id: ?, id: ?, opponent1: { result: ? }, opponent2: { result: ? } }, /* Following */]

matchGamesToBeUpdated.map(async (matchGame) => {
  await window.bracketsManager.update.matchGame(matchGame);
});

Question:
Is this a bug or suppose the match game should be only updated for once?

[Drarig29]

It seems like a bug. But you are not updating match games right: you shouldn't give an id and a parentId.

You must give either just an id or both a parentId and a number.

Maybe it will fix your issue.

[yongshun950824]

Okay, thanks for the assist. Tried the suggested approach with these scenarios:

Scenario 1: only id
or
Scenario 2: both parentId and number

But I still cannot perform the re-update for the same match game.

When re-updates the match game, it will lead to the parent match's result and score being wrong.

I think it's good to share the complete code for your reference:

This function will be executed for every time button click

// Start: Data prepared for querying and update

let matchInfo = { groupId: ?, roundNumber: ?, matchNumber: ? };
let updatedMatchGameInfos = [
    { number: ?, opponent1: { result: ? }, opponent2: { result: ? } }
    // At least 1 or more match_games to update
];

// End

let match = await window.bracketsManager.get.findMatch(matchInfo.groupId, matchInfo.roundNumber, matchInfo.matchNumber);


await Promise.all(
    updatedMatchGameInfos.map(async (updatedMatchGame) => {
        let matchGame = await window.bracketsManager.get.findMatchGame({
            parent_id: match.id,
            number: updatedMatchGame.number
        });

        let newValue = {
            id: matchGame.id,
            opponent1: updatedMatchGame.opponent1,
            opponent2: updatedMatchGame.opponent2
        };

        await window.bracketsManager.update.matchGame(newValue);

        return updatedMatchGame;
    })
).finally(() => {
    // Render data with `window.inMemoryDatabase.data`
});

[Drarig29]

In your function, you are not forced to do:

let matchGame = await window.bracketsManager.get.findMatchGame({
    parent_id: match.id,
    number: updatedMatchGame.number
});

let newValue = {
    id: matchGame.id,
    opponent1: updatedMatchGame.opponent1,
    opponent2: updatedMatchGame.opponent2
};

await window.bracketsManager.update.matchGame(newValue);

You can do that instead:

let newValue = {
    parent_id: match.id,
    number: updatedMatchGame.number,
    opponent1: updatedMatchGame.opponent1,
    opponent2: updatedMatchGame.opponent2
};

await window.bracketsManager.update.matchGame(newValue);

---

I tested on my side:

describe('Debug discussion', () => {

    it('first update', async () => {
        storage.reset();

        await manager.create({
            tournamentId: 0,
            name: 'Example',
            type: 'single_elimination',
            seeding: ['Team 1', 'Team 2', 'Team 3', 'Team 4'],
            settings: { matchesChildCount: 3 },
        });

        await manager.update.matchGame({
            parent_id: 0,
            number: 1,
            opponent1: { result: 'win' },
            opponent2: { result: 'loss' },
        });
    });

    it('second update', async () => {
        await manager.update.matchGame({
            parent_id: 0,
            number: 1,
            opponent1: { result: 'loss' },
            opponent2: { result: 'win' },
        });
    });
});

And this works perfectly...

After the second update, I get this:

{
    "id": 0,
    "number": 1,
    "stage_id": 0,
    "group_id": 0,
    "round_id": 0,
    "child_count": 3,
    "status": 3,
    "opponent1": {
        "id": 0,
        "position": 1,
        "score": 0
    },
    "opponent2": {
        "id": 3,
        "position": 4,
        "score": 1
    }
},

---

Are you sure you understood well that, to report the results of the 3 match games of a specific match, you need to update each game with each number property?

await window.bracketsManager.update.matchGame({ parent_id: 0, number: 1, opponent1: { result: "win" }, opponent2: { result: "loss" } })

await window.bracketsManager.update.matchGame({ parent_id: 0, number: 2, opponent1: { result: "loss" }, opponent2: { result: "win" } })

await window.bracketsManager.update.matchGame({ parent_id: 0, number: 3, opponent1: { result: "loss" }, opponent2: { result: "win" } })

Should return:

{
    "id": 0,
    "number": 1,
    "stage_id": 0,
    "group_id": 0,
    "round_id": 0,
    "child_count": 3,
    "status": 4,
    "opponent1": {
        "id": 0,
        "position": 1,
        "score": 1,
        "result": "loss"
    },
    "opponent2": {
        "id": 3,
        "position": 4,
        "score": 2,
        "result": "win"
    }
},

[yongshun950824]

Thanks for the replies and also the efforts.

I try to play around with F12 Debugging Tools Console, still no luck from my side =(

Debugging log

window.inMemoryDatabase.data.stage[0]
{id: 0, tournament_id: 6, name: 'Random S7', type: 'single_elimination', number: 7, …}id: 0name: "Random S7"number: 7settings: {size: 4, seedOrdering: Array(1), grandFinal: null, matchesChildCount: 2, groupCount: null, …}grandFinal: nullgroupCount: nullmatchesChildCount: 2roundRobinMode: nullseedOrdering: ['inner_outer']size: 4skipFirstRound: null[[Prototype]]: Objecttournament_id: 6type: "single_elimination"[[Prototype]]: Object
window.inMemoryDatabase.data.match[0]
{id: 0, number: 1, stage_id: 0, group_id: 0, round_id: 0, …}child_count: 2group_id: 0id: 0number: 1opponent1: {id: 0, position: 1}opponent2: {id: 4, position: 4}round_id: 0stage_id: 0status: 2[[Prototype]]: Object
await window.bracketsManager.update.matchGame({
            parent_id: 0,
            number: 1,
            opponent1: { result: 'win' },
            opponent2: { result: 'loss' },
        });
undefined
window.inMemoryDatabase.data.match[0]
{id: 0, number: 1, stage_id: 0, group_id: 0, round_id: 0, …}child_count: 2group_id: 0id: 0number: 1opponent1: {id: 0, position: 1, score: 1}opponent2: {id: 4, position: 4, score: 0}round_id: 0stage_id: 0status: 3[[Prototype]]: Object
await window.bracketsManager.update.matchGame({
            parent_id: 0,
            number: 1,
            opponent1: { result: 'loss' },
            opponent2: { result: 'win' },
        });
undefined
window.inMemoryDatabase.data.match[0]
{id: 0, number: 1, stage_id: 0, group_id: 0, round_id: 0, …}child_count: 2group_id: 0id: 0number: 1opponent1: {id: 0, position: 1, score: 0, result: 'loss'}opponent2: {id: 4, position: 4, score: 2, result: 'win'}round_id: 0stage_id: 0status: 4[[Prototype]]: Objectconstructor: ƒ Object()hasOwnProperty: ƒ hasOwnProperty()isPrototypeOf: ƒ isPrototypeOf()propertyIsEnumerable: ƒ propertyIsEnumerable()toLocaleString: ƒ toLocaleString()toString: ƒ toString()valueOf: ƒ valueOf()__defineGetter__: ƒ __defineGetter__()__defineSetter__: ƒ __defineSetter__()__lookupGetter__: ƒ __lookupGetter__()__lookupSetter__: ƒ __lookupSetter__()__proto__: (...)get __proto__: ƒ __proto__()set __proto__: ƒ __proto__()

Version: 1.4.0

[Drarig29]

Ok, I'm "glad" to say that I could reproduce your issue in the documentation's console.

And the exact same steps work in the Node.js version... I really believe this is an issue with the InMemoryDatabase and references being indirectly modified and doing side effects... I'll continue debugging this tomorrow during this weekend.

---

The first hint that there is a bug is the following. After the first update, the first match game contains:

{
    "id": 0,
    "number": 1,
    "stage_id": 0,
    "parent_id": 0,
    "status": 4,
    "opponent1": {
        "id": 0
    },
    "opponent2": {
        "id": 3
    }
}

Whereas it should actually contain:

{
    "id": 0,
    "number": 1,
    "stage_id": 0,
    "parent_id": 0,
    "status": 4,
    "opponent1": {
        "id": 0,
        "result": "loss"
    },
    "opponent2": {
        "id": 3,
        "result": "win"
    }
},

[Drarig29]

I found the issue, it's because of an opponent overwrite instead of a merge (like node-json-db does) in InMemoryDatabase's update method.

I'll fix this weekend and publish a new version of brackets-memory-db, now I have to go.

[Drarig29]

This should be fixed if you use [email protected].

I also released a new version of the viewer: [email protected].

[yongshun950824]

This is awesome, I tested on my side and it works correctly for updating the match games multiple times and reflecting the correct result for the parent match part.

Thanks for your gargantuan efforts and sorry that this fix costs your weekends.