BYE not working with MongoDB #168

MrEngineerET · 2023-06-13T04:24:16Z

MrEngineerET
Jun 13, 2023

I am creating a double elimination stage with a participant number, not a power of 2. The winner bracket works as expected, but the loser bracket doesn't work. The following attached picture explains the issue well. Is there any manual operation i should do on the loser bracket matches?

I have also attached the JSON data of the tournament:

JSON data

[{
  "_id": {
    "$numberLong": "1686629031837"
  },
  "name": "BYE Double Elimination",
  "description": "this is the description",
  "match_game": [],
  "game": [],
  "status": "progress",
  "createdBy": {
    "$oid": "6447a1a9a4d5fae81eb6ed83"
  },
  "participant": [
    {
      "id": 0,
      "tournament_id": {
        "$numberLong": "1686629031837"
      },
      "name": "One",
      "_id": {
        "$oid": "6487eaa7ec5c1009c85764f5"
      }
    },
    {
      "id": 1,
      "tournament_id": {
        "$numberLong": "1686629031837"
      },
      "name": "Two",
      "_id": {
        "$oid": "6487eaa7ec5c1009c85764f6"
      }
    },
    {
      "id": 2,
      "tournament_id": {
        "$numberLong": "1686629031837"
      },
      "name": "Three",
      "_id": {
        "$oid": "6487eaa7ec5c1009c85764f7"
      }
    },
    {
      "id": 3,
      "tournament_id": {
        "$numberLong": "1686629031837"
      },
      "name": "Four",
      "_id": {
        "$oid": "6487eaa7ec5c1009c85764f8"
      }
    },
    {
      "id": 4,
      "tournament_id": {
        "$numberLong": "1686629031837"
      },
      "name": "Five",
      "_id": {
        "$oid": "6487eaa7ec5c1009c85764f9"
      }
    }
  ],
  "stage": [
    {
      "id": 0,
      "tournament_id": {
        "$numberLong": "1686629031837"
      },
      "name": "BYE Double Elimination",
      "type": "double_elimination",
      "number": 1,
      "settings": {
        "seedOrdering": [
          "natural"
        ],
        "matchesChildCount": 0,
        "size": 8,
        "grandFinal": "double"
      },
      "_id": {
        "$oid": "6487eaa7ec5c1009c85764fb"
      }
    }
  ],
  "group": [
    {
      "id": 0,
      "number": 1,
      "stage_id": 0,
      "_id": {
        "$oid": "6487eaa7ec5c1009c85764fd"
      }
    },
    {
      "id": 1,
      "number": 2,
      "stage_id": 0,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576523"
      }
    },
    {
      "id": 2,
      "number": 3,
      "stage_id": 0,
      "_id": {
        "$oid": "6487eaa7ec5c1009c857657b"
      }
    }
  ],
  "round": [
    {
      "id": 0,
      "number": 1,
      "group_id": 0,
      "stage_id": 0,
      "_id": {
        "$oid": "6487eaa7ec5c1009c85764ff"
      }
    },
    {
      "id": 1,
      "number": 2,
      "group_id": 0,
      "stage_id": 0,
      "_id": {
        "$oid": "6487eaa7ec5c1009c857650c"
      }
    },
    {
      "id": 2,
      "number": 3,
      "group_id": 0,
      "stage_id": 0,
      "_id": {
        "$oid": "6487eaa7ec5c1009c857651a"
      }
    },
    {
      "id": 3,
      "number": 1,
      "group_id": 1,
      "stage_id": 0,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576527"
      }
    },
    {
      "id": 4,
      "number": 2,
      "group_id": 1,
      "stage_id": 0,
      "_id": {
        "$oid": "6487eaa7ec5c1009c857653d"
      }
    },
    {
      "id": 5,
      "number": 3,
      "group_id": 1,
      "stage_id": 0,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576558"
      }
    },
    {
      "id": 6,
      "number": 4,
      "group_id": 1,
      "stage_id": 0,
      "_id": {
        "$oid": "6487eaa7ec5c1009c857656b"
      }
    },
    {
      "id": 7,
      "number": 1,
      "group_id": 2,
      "stage_id": 0,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576583"
      }
    },
    {
      "id": 8,
      "number": 2,
      "group_id": 2,
      "stage_id": 0,
      "_id": {
        "$oid": "6487eaa7ec5c1009c857659a"
      }
    }
  ],
  "match": [
    {
      "opponent1": {
        "id": 0,
        "position": 1,
        "score": 3,
        "result": "win"
      },
      "opponent2": {
        "id": 1,
        "position": 2,
        "score": 1,
        "result": "loss"
      },
      "id": 0,
      "number": 1,
      "group_id": 0,
      "stage_id": 0,
      "round_id": 0,
      "child_count": 0,
      "status": 5,
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576501"
      }
    },
    {
      "opponent1": {
        "id": 2,
        "position": 3
      },
      "id": 1,
      "number": 2,
      "group_id": 0,
      "stage_id": 0,
      "round_id": 0,
      "child_count": 0,
      "status": 5,
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576503"
      }
    },
    {
      "opponent1": {
        "id": 3,
        "position": 5
      },
      "id": 2,
      "number": 3,
      "group_id": 0,
      "stage_id": 0,
      "round_id": 0,
      "child_count": 0,
      "status": 5,
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576506"
      }
    },
    {
      "opponent1": {
        "id": 4,
        "position": 7
      },
      "id": 3,
      "number": 4,
      "group_id": 0,
      "stage_id": 0,
      "round_id": 0,
      "child_count": 0,
      "status": 5,
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c857650a"
      }
    },
    {
      "opponent1": {
        "id": 0,
        "score": 5,
        "result": "loss"
      },
      "opponent2": {
        "id": 2,
        "score": 7,
        "result": "win"
      },
      "id": 4,
      "number": 1,
      "group_id": 0,
      "stage_id": 0,
      "round_id": 1,
      "child_count": 0,
      "status": 5,
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576511"
      }
    },
    {
      "opponent1": {
        "id": 3,
        "score": 2,
        "result": "win"
      },
      "opponent2": {
        "id": 4,
        "score": 1,
        "result": "loss"
      },
      "id": 5,
      "number": 2,
      "group_id": 0,
      "stage_id": 0,
      "round_id": 1,
      "child_count": 0,
      "status": 5,
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576517"
      }
    },
    {
      "id": 6,
      "number": 1,
      "group_id": 0,
      "stage_id": 0,
      "round_id": 2,
      "child_count": 0,
      "status": 4,
      "opponent1": {
        "id": 2,
        "score": 2,
        "result": "win"
      },
      "opponent2": {
        "id": 3,
        "score": 1,
        "result": "loss"
      },
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576521"
      }
    },
    {
      "opponent1": {
        "id": 1,
        "position": 1
      },
      "id": 7,
      "number": 1,
      "group_id": 1,
      "stage_id": 0,
      "round_id": 3,
      "child_count": 0,
      "status": 2,
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c857652f"
      }
    },
    {
      "id": 8,
      "number": 2,
      "group_id": 1,
      "stage_id": 0,
      "round_id": 3,
      "child_count": 0,
      "status": 0,
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576538"
      }
    },
    {
      "opponent1": {
        "id": 0,
        "position": 2
      },
      "opponent2": {
        "id": null
      },
      "id": 9,
      "number": 1,
      "group_id": 1,
      "stage_id": 0,
      "round_id": 4,
      "child_count": 0,
      "status": 1,
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576547"
      }
    },
    {
      "opponent1": {
        "id": 4,
        "position": 1
      },
      "id": 10,
      "number": 2,
      "group_id": 1,
      "stage_id": 0,
      "round_id": 4,
      "child_count": 0,
      "status": 2,
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576552"
      }
    },
    {
      "id": 11,
      "number": 1,
      "group_id": 1,
      "stage_id": 0,
      "round_id": 5,
      "child_count": 0,
      "status": 0,
      "opponent1": {
        "id": null
      },
      "opponent2": {
        "id": null
      },
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576564"
      }
    },
    {
      "opponent1": {
        "id": 3,
        "position": 1
      },
      "opponent2": {
        "id": null
      },
      "id": 12,
      "number": 1,
      "group_id": 1,
      "stage_id": 0,
      "round_id": 6,
      "child_count": 0,
      "status": 1,
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576578"
      }
    },
    {
      "opponent1": {
        "id": 2
      },
      "opponent2": {
        "id": null,
        "position": 1
      },
      "id": 13,
      "number": 1,
      "group_id": 2,
      "stage_id": 0,
      "round_id": 7,
      "child_count": 0,
      "status": 1,
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c8576591"
      }
    },
    {
      "id": 14,
      "number": 1,
      "group_id": 2,
      "stage_id": 0,
      "round_id": 8,
      "child_count": 0,
      "status": 0,
      "opponent1": {
        "id": null
      },
      "opponent2": {
        "id": null
      },
      "gameId": null,
      "_id": {
        "$oid": "6487eaa7ec5c1009c85765a9"
      }
    }
  ]
}]

Answered by MrEngineerET

Jun 30, 2023

Sorry, the issue was from my CRUD implementation.
Earlier my schema for opponents was

opponent1: {
          id: Number,
          position: Number,
          score: Number,
          result: { type: String, enum: ["win", "loss"] },
        },

Then after updating my schema to support a null value, it works

 opponent1: {
         type: Object,
         default: null,
         id: Number,
         position: Number,
         score: Number,
         result: { type: String, enum: ["win", "loss"] },
       },

View full answer

Drarig29 · 2023-06-13T21:17:24Z

Drarig29
Jun 13, 2023
Maintainer

I love your bracket design! ❤️ (did you fork the viewer, or is it only customizations?)

Would you have an history of the order in which the matches were completed?
I tried to reproduce your issue, but everything seems fine...

storage.reset()

await manager.create({
    name: 'Example',
    tournamentId: 0,
    type: 'double_elimination',
    seeding: ['One', 'Two', 'Three', 'Four', 'Five'],
    settings: {
        grandFinal: 'double',
        size: 8,
        seedOrdering: ['natural', 'natural', 'natural'],
        balanceByes: true
    },
});

await manager.update.match({
    id: 0,
    opponent1: { score: 3, result: 'win' },
    opponent2: { score: 1 },
});

await manager.update.match({
    id: 4,
    opponent1: { score: 5 },
    opponent2: { score: 7, result: 'win' },
});

await manager.update.match({
    id: 5,
    opponent1: { score: 2, result: 'win' },
    opponent2: { score: 1 },
});

await manager.update.match({
    id: 6,
    opponent1: { score: 2, result: 'win' },
    opponent2: { score: 1 },
});

Which produces the following output (see screenshot). So either your matches were completed in a different order which revealed an edge case, or your storage implementation may be wrong 🤔

1 reply

MrEngineerET Jun 14, 2023
Author

I love your bracket design! ❤️ (did you fork the viewer, or is it only customizations?)

Thanks a lot. I didn't fork the viewer. I implemented it from scratch using React.

So either your matches were completed in a different order which revealed an edge case, or your storage implementation may be wrong 🤔

I checked and we both followed the same order, which leaves us with the storage implementation. I have sent you the storage implementation to your email.

MrEngineerET · 2023-06-30T08:23:27Z

MrEngineerET
Jun 30, 2023
Author

Sorry, the issue was from my CRUD implementation.
Earlier my schema for opponents was

opponent1: {
          id: Number,
          position: Number,
          score: Number,
          result: { type: String, enum: ["win", "loss"] },
        },

Then after updating my schema to support a null value, it works

 opponent1: {
         type: Object,
         default: null,
         id: Number,
         position: Number,
         score: Number,
         result: { type: String, enum: ["win", "loss"] },
       },

1 reply

Drarig29 Jun 30, 2023
Maintainer

Ha, thank you... sorry I didn't have time to check this. Glad you found the issue, cheers!

MrEngineerET · 2023-06-30T10:36:23Z

MrEngineerET
Jun 30, 2023
Author

Hello Dear, I think I have also found an error. If you update the consolidation match before the final game, the final game gets archived. ```js await manager.create({ name: 'Example', tournamentId: 0, type: 'single_elimination', seeding: ['Team 1', 'Team 2', 'Team 3', 'Team 4'], settings: { consolationFinal: true }, }); await manager.update.match({ id: 0, opponent1: { score: 16, result: 'win' }, opponent2: { score: 12 }, }); await manager.update.match({ id: 1, opponent1: { score: 16, result: 'win' }, opponent2: { score: 12 }, }); await manager.update.match({ id: 3, opponent1: { score: 16, result: 'win' }, opponent2: { score: 12 }, }); console.log((await manager.export()).match); ``` Here is the output ```json [ { "id": 0, "number": 1, "stage_id": 0, "group_id": 0, "round_id": 0, "child_count": 0, "status": 4, "opponent1": { "id": 0, "position": 1, "score": 16, "result": "win" }, "opponent2": { "id": 3, "position": 4, "score": 12, "result": "loss" } }, { "id": 1, "number": 2, "stage_id": 0, "group_id": 0, "round_id": 0, "child_count": 0, "status": 4, "opponent1": { "id": 1, "position": 2, "score": 16, "result": "win" }, "opponent2": { "id": 2, "position": 3, "score": 12, "result": "loss" } }, { "id": 2, "number": 1, "stage_id": 0, "group_id": 0, "round_id": 1, "child_count": 0, "status": 5, "opponent1": { "id": 0 }, "opponent2": { "id": 1 } }, { "id": 3, "number": 1, "stage_id": 0, "group_id": 1, "round_id": 2, "child_count": 0, "status": 4, "opponent1": { "id": 3, "position": 1, "score": 16, "result": "win" }, "opponent2": { "id": 2, "position": 2, "score": 12, "result": "loss" } } ] ```

2 replies

Drarig29 Jun 30, 2023
Maintainer

Thanks, I created an issue out of this.

Drarig29 Jun 30, 2023
Maintainer

@MrEngineerET a fix was released in v1.5.10

MrEngineerET · 2023-07-01T12:23:31Z

MrEngineerET
Jul 1, 2023
Author

Thank you very much, I appreciate it.

…

On Sat, 1 Jul 2023 at 01:29, Corentin Girard ***@***.***> wrote: @MrEngineerET <https://github.com/MrEngineerET> a fix was released in v1.5.10 <https://github.com/Drarig29/brackets-manager.js/releases/tag/v1.5.10> — Reply to this email directly, view it on GitHub <#168 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALIZX7JY7XSCQXSBONZHRM3XN5HLNANCNFSM6AAAAAAZEII2VU> . You are receiving this because you were mentioned.Message ID: ***@***.*** .com>

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BYE not working with MongoDB #168

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 4 comments 4 replies

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

Select a reply

BYE not working with MongoDB #168

MrEngineerET Jun 13, 2023

Replies: 4 comments · 4 replies

Drarig29 Jun 13, 2023 Maintainer

MrEngineerET Jun 14, 2023 Author

MrEngineerET Jun 30, 2023 Author

Drarig29 Jun 30, 2023 Maintainer

MrEngineerET Jun 30, 2023 Author

Drarig29 Jun 30, 2023 Maintainer

Drarig29 Jun 30, 2023 Maintainer

MrEngineerET Jul 1, 2023 Author

MrEngineerET
Jun 13, 2023

Replies: 4 comments 4 replies

Drarig29
Jun 13, 2023
Maintainer

MrEngineerET Jun 14, 2023
Author

MrEngineerET
Jun 30, 2023
Author

Drarig29 Jun 30, 2023
Maintainer

MrEngineerET
Jun 30, 2023
Author

Drarig29 Jun 30, 2023
Maintainer

Drarig29 Jun 30, 2023
Maintainer

MrEngineerET
Jul 1, 2023
Author