Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent TotalContributor animation from recomposition on scroll #1012

Conversation

rocoand
Copy link
Contributor

@rocoand rocoand commented Sep 8, 2024

Issue

Overview (Required)

  • Changed targetValue from remember to rememberSaveable
    • I thought this problem was caused by recomposition by scrolling.
    • To avoid this I used rememberSaveable.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Movie (Optional)

Before After
365412364-d08ca095-7f0f-4388-8ad0-83de041987fa.mp4
Screen_recording_20240909_012304.mp4

@takahirom
Copy link
Member

Looks great! Thank you for your contribution!

@takahirom takahirom merged commit 82bcd5c into DroidKaigi:main Sep 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe ContributorsCount animation should only be at the beginning of screen transition
2 participants