Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗑️ DropUnlessResumed is causing navigation issues on AboutScreen, so DropUnlessResumed is removed. #1018

Merged

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Sep 9, 2024

Issue

Overview (Required)

  • When the same item in the BottomNavigation is tapped, lifecycleOwner.lifecycle.currentState becomes DESTROYED and becomes impossible to tap.
  • If you scroll, it will return to RESUMED and become tapable again.
  • Because the number of days remaining until DroidKaigi is limited, there is no time to spare to deal with this phenomenon in a fundamental way.
  • For now, it would be best to remove it.
2024-09-09.21.13.342.mov

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 9, 2024 11:48 Inactive
@Corvus400 Corvus400 marked this pull request as ready for review September 9, 2024 12:27
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the issues a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants