Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [TimetableItemDetailScreen] I added a UI to display a message in the event of cancellation. #1026

Merged
merged 2 commits into from
Sep 10, 2024
Merged

✨ [TimetableItemDetailScreen] I added a UI to display a message in the event of cancellation. #1026

merged 2 commits into from
Sep 10, 2024
+114 −2

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Sep 10, 2024 •
edited
Loading

Issue

Overview (Required)

  • A UI has been added to display messages on the TimetableItemDetailScreen when messages exist.
  • We have added VRT to check that the added UI is functioning.

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2024 06:16 Inactive
@github-actions GitHub Actions
Copy link

Snapshot diff report

File name Image
TimetableItemDetailS
creenPreview_compare
.png
TimetableItemDetailS
creenTest[TimetableI
temDetailScreen - wh
en server is operati
onal exists message
- when launch - it s
hould display messag
e]_compare.png

@Corvus400 Corvus400 marked this pull request as ready for review September 10, 2024 06:27
takahirom
takahirom approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@takahirom takahirom merged commit 92f49c7 into DroidKaigi:main Sep 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If there is a message in Session, it would be better to display it on the TimetableItemDetailScreen as well
2 participants
@Corvus400 @takahirom