-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test project tests fail on Linux machines #359
Comments
Did PR #360 close this issue? I don't think that this issue description is helpful, e.g., there is no reproducible example; there is no example output of the error message, it doesn't state which database (out of >= 3), etc. Also claiming that this is an issue for (all) Linux machines is not helpful; travis-ci which we run with
Maybe it fails on your specific Linux machine, but then writing what setup you use would be more helpful for debugging. As it is, I see no specific reason why this was an issue with the R code of rSFSW2 and not with your specific setup. Commit bdc6062 introduces new code to replace any We used to remove NAs in weather folder names with Line 1843 in fc06354
InputMaster csv, i.e., we started to write "NA" instead of NA to the csv file (db3948e). Thus, the reference output database contains an entry for site 4 "NA". I guess that maybe my local computer and travis-ci, translate this into "NA" while yours reads it as NA from disk? The "NA" has ended up in the reference output database because it was no longer removed by na.exclude . Thus, if this is the problem, then I guess that instead of laboriously rewriting the NA s into "NA" s, simply removing the na.exclude (maybe with an additional as.character(SFSW2_prj_inputs[["SWRunInformation"]]$WeatherFolder) if needed) would produce the same result as the reference output database, but much easier and faster?
Since, originally these Either way, looping over vectors tends to be slow and in our use cases
is equivalent to
Here, an example with 100,000 sites -- a reasonable setup for one of our simulation experiments: the for-loop is (on my machine) over 1,300 times slower...
But again, simply removing
|
Test project tests fail on Linux machines due to "NA" being coerced to NA in Linux and thus site 4 is skipped on database generation.
The text was updated successfully, but these errors were encountered: