Skip to content
This repository was archived by the owner on Feb 27, 2025. It is now read-only.

Remove files from blocklist #438

Closed
vedarshshah opened this issue Sep 9, 2023 · 1 comment
Closed

Remove files from blocklist #438

vedarshshah opened this issue Sep 9, 2023 · 1 comment
Labels
systems Related to building and automation (docker/github)

Comments

@vedarshshah
Copy link
Member

vedarshshah commented Sep 9, 2023 •
edited
Loading

Background

We added task_runner.launch to the block list of launch files to avoid the check going over legacy code using ROS actions. This change needs to be reversed when task planning has been modified to remove usage of ROS actions.

We also added vectornav.launch, tasks.launch, and motion.launch to the block list since vectornav.launch results in an error when it can't find the IMU. The latter two files depend on vectornav.launch. This change needs to be reversed when the error in vectornav.launch is suppressed.

Purpose

Remove task_runner.launch, vectornav.launch, tasks.launch, and motion.launch from the block list of launch files.
@vedarshshah vedarshshah added the task planning Related to task planning label Sep 9, 2023
@vedarshshah vedarshshah changed the title Remove task_runner.launch from blocklist Remove files from blocklist Sep 25, 2023
@vedarshshah vedarshshah added systems Related to building and automation (docker/github) and removed task planning Related to task planning labels Sep 25, 2023
@vedarshshah vedarshshah modified the milestone: Fall 2023 Sep 25, 2023
@vedarshshah
Copy link
Member Author

No longer necessary as robosub-ros will be archived.

@vedarshshah vedarshshah closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
systems Related to building and automation (docker/github)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vedarshshah