Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process: we should not be deleting build directories after a build - they are deleted beforehand anyway, and may contain useful info #1246

Open
dyaandys opened this issue Jul 11, 2024 · 1 comment
Assignees
Labels
1h Small issue est. to take less than 1 hour enhancement

Comments

@dyaandys
Copy link
Contributor

At 0978c51

In Jenkinsfile we have
rm -rf _ ship
build_ride
stash ship
rm -rf _ ship

That last rm -rf is both unnecessary, and also unhelpful - if the builds thinks it's been successful but hasn't all the files will have been deleted which is unhelpful ! So let's delete that second rm -rf.

@dyaandys dyaandys added enhancement 1h Small issue est. to take less than 1 hour labels Jul 11, 2024
@dyaandys dyaandys self-assigned this Jul 11, 2024
dyaandys added a commit that referenced this issue Jul 11, 2024
@dyaandys
Copy link
Contributor Author

As a minor aside, the stage should be called "Notarise" .. I'll make the change to see if the build is successful .. and then change one rm at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1h Small issue est. to take less than 1 hour enhancement
Projects
None yet
Development

No branches or pull requests

1 participant