Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: use decorators rather than wrapper classes #44

Open
carynbear opened this issue May 15, 2024 · 0 comments
Open

improve: use decorators rather than wrapper classes #44

carynbear opened this issue May 15, 2024 · 0 comments
Labels

Comments

@carynbear
Copy link
Collaborator

The issue with AlgorithmChecker and SystemChecker is that methods/attributes are not forwarded to the wrapped class which reduces the flexibility of DynaDojo.

For example, you cannot access an underlying Tensorflow or Pytorch neural net model without first calling ._alg which means you can't move the model to GPU natively.

I think we should migrate to using decorators.

Relevant stackoverflow post: https://stackoverflow.com/a/63644860

@carynbear carynbear added the enhancement New feature or request label May 15, 2024
@carynbear carynbear changed the title Use decorators rather than wrapper classes improve: use decorators rather than wrapper classes Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant