Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes demo bugs #57, #58, #60 #73

Closed
wants to merge 4 commits into from

Conversation

VictorHuynh
Copy link
Collaborator

Changes:

  • Replaced 'reps' with 'trials'
  • Made a sketchy fix with [fc_dnn_nbody_demo], adding an arbitrary extra param
    • could use further review
  • Did not fix demos completely, just fixed some bugs

Issues Addressed:

Mostly replaced 'reps' with 'trials.' Made a sketchy fix with fc_dnn_nbody_demo, adding an arbitrary extra param -- could use further review. Did not fix demos completely, just fixed some bugs
@VictorHuynh VictorHuynh changed the title fix demo bugs Fixes #57, #58, #60: fix demo bugs Jun 28, 2024
@carynbear
Copy link
Collaborator

carynbear commented Jul 2, 2024

@VictorHuynh please edit your pull request to match the guidelines in CONTRIBUTING.md https://github.com/DynaDojo/dynadojo/blob/main/CONTRIBUTING.md#pull-request-checklist

@VictorHuynh VictorHuynh changed the title Fixes #57, #58, #60: fix demo bugs fix: fixes demo bugs #57, #58, #60 Jul 2, 2024
@carynbear
Copy link
Collaborator

@VictorHuynh Please submit each change as a separate pull request to avoid conflicts. I believe some of these changes are already fixed by others' pull requests.

@carynbear carynbear closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

demo/bug: sindy_lorenz_demo2 demo/bug: fts_sindy_lorenz_demo demo/bug: fts_dmd_lds_demo
2 participants