Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depo-Curation -: Invalid submission should not be considered while putting old GCST for MetaData upload #210

Open
sajo-ebi opened this issue Mar 19, 2024 · 4 comments

Comments

@sajo-ebi
Copy link
Collaborator

At the moment the Depo curation logic to update metadata also considers invalid submission to match study tags to assign GCST to the studies we need to stop this to avoid wrong GCST being assigned

@jiyue1214
Copy link

Originally from Santhi's ticket, GCST90319472 got changed to GCST90308719 and decided to keep GCST90308719 and move sumstats from GCST90319472 to GCST90308719.

Currently, when I tried to harmonise these studies, we found:

GCST UI mangodb rest_API ingest_API ftp md5sum of sumstat
GCST90308719 yes yes yes yes yes c4d5a8e5048e280987718976bd262fd6
GCST90319471 no yes no no yes f03306932b3c2d260ddbb69e0efa7b34
GCST90319472 yes yes no no yes f03306932b3c2d260ddbb69e0efa7b34

To clean the data here, maybe we can:

  1. on FTP and staging: delete GCST90319471, replacing the file in GCST90308719 with GCST90319472 @Santhi1901, could I ask if it is correct? (data in the GCST90308719 folder is not correct).
  2. from the UI, disabled users to search the data via GCST90319472.

@Santhi1901
Copy link

  1. I had copied the sumstats from GCST90319472 to GCST90308719, and later the user approached us, mentioning that the header for effect allele and other alleles was mismarked. They had sent the new file, and I corrected those in GCST90308719. So, the files in GCST90308719 should be correct. Is there any problem with sumstats in this @jiyue1214 ?

For GCST90319471, I don't have any data regarding this.

  1. Yes, this can disabled

@jiyue1214
Copy link

Hi, @Santhi1901. Thanks for confirming. I saw the md5 of the GCST90308719 and GCST90319472 are different, and not sure which data is correct. Since the GCST90308719 is the correct one, I can see that GCST90308719 is already harmonised successfully. Could I delete GCST90319472?

@Santhi1901
Copy link

yes, GCST90319472 can be deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants