Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortran component build #168

Open
1 task
jdhughes-usgs opened this issue May 12, 2023 · 3 comments
Open
1 task

Fortran component build #168

jdhughes-usgs opened this issue May 12, 2023 · 3 comments
Assignees

Comments

@jdhughes-usgs
Copy link
Contributor

Currently, from numpy.distutils.misc_util.Configuration is used to build Fortran components. This approach is currently deprecated. When running

python -m build

The following is reported:

`numpy.distutils` is deprecated since NumPy 1.23.0, as a result
  of the deprecation of `distutils` itself. It will be removed for
  Python >= 3.12. For older Python versions it will remain present.
  It is recommended to use `setuptools < 60.0` for those Python versions.
  For more details, see:
https://numpy.org/devdocs/reference/distutils_status_migration.html 

TODO:

  • Find a solution that relies on setuptools.

Also, since it seems we are getting ~equivalent performance using numba maybe we should

  1. only worry about fortran for development installation from the repo or
  2. consider dropping fortran options to simplify pywatershed
@jdhughes-usgs jdhughes-usgs added this to the 0.1.3 milestone May 12, 2023
@jmccreight
Copy link
Member

I think we should adopt Fortran as develop only until we find some reason to motivate us or signal we should drop fortran.

The pathway from numba to fortran to compiled code is something I've enjoyed and maybe a reason Fortran sticks around, but maybe it's not necessary.

@jmccreight
Copy link
Member

with #188 fortran compiles are only for editable installs.

@jmccreight jmccreight removed this from the 2.0.0 milestone Jun 18, 2024
@jmccreight
Copy link
Member

pip 25 is going to deprecated legacy-editable installs and will force the issue at that time.
The fortran is no longer being tested in CI but is still available. Deprecation seems likely, pending some more performance comparisons against numba.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants