EDDI not listing planets that should be scanned

[Titanicom]

Some time ago, I noticed that EDDI was no longer advising me to scan high value planets in systems that I was visiting for the first time.

Now EDDI may suggest scannig other planets in the system just after I finish scanning a planet for my own reasons. This is often hit-and-miss, as it doesn't always offer the advice.

Do you know if anything has changed that would affect this function?

[Tkael]

Hi there. I've converted this to a discussion since it does not follow the template for an issue / bug report and doesn't provide enough information (yet) for me to be able to replicate a problem.

My first question is whether you are using the Discovery Scanner (as that is one of the triggers for the Bodies to map script)?
The second would be to verify that you are using the FSS scanner to scan all of the bodies (as EDDI cannot recommend mapping a body that has neither been scanned by you nor sent to EDSM previously)?
The third would be to verify whether the bodies in question have been previously scanned and mapped by another commander (as depending on the EDDI version you are using the default script might not recommend bodies which have been previously mapped)?

For reference, here's the version of the Bodies to map script that I'm currently planning to include in the next release. It includes a new settable option for whether the script should recommend previously mapped bodies.

{_ Preferences: _}
{set recommendAlreadyMapped to true}   {_ If true, recommend bodies that have already been mapped by other players _}
{set reportTerraformables to true}     {_ If true, all terraformable and terraformed bodies shall be mapping candidates _}
{set highValueThreshold to 80000}      {_ All bodies with a minimum estimated scan value exceeding this threshold shall be mapping candidates _}
 
{_ When true, these planet types shall be mapping candidates _}
{set reportPlanetTypes to [
    "Ammonia world": true,
    "Earth-like world": true,
    "Gas giant with ammonia based life": false,
    "Gas giant with water based life": false,
    "Helium gas giant": false,
    "Helium-rich gas giant": false,
    "High metal content world": false,
    "Icy body": false,
    "Metal-rich body": false,
    "Rocky body": false,
    "Rocky ice world": false,
    "Class I gas giant": false,
    "Class II gas giant": false,
    "Class III gas giant": false,
    "Class IV gas giant": false,
    "Class V gas giant": false,
    "Water giant": false,
    "Water giant with life": false,
    "Water world": true,
]}

{_ Fetch from Context, if a context is set _}
{if state.eddi_context_system_name:
    {set reportSystem to SystemDetails(state.eddi_context_system_name)}
|else:
    {set reportSystem to SystemDetails(system.systemname)}
}

{_ Identify bodies worth mapping _}

{set toMapList to []}
{set mappedBodies to 0}
{set totalBodies to 0}

{for compartment in ship.compartments:
    {if compartment.module.invariantName = "Detailed Surface Scanner":
        {set hasDSS to true}
    }
}
        
{if hasDSS:
    {for body in reportSystem.bodies:
        {set totalBodies to totalBodies + 1}
        {if body.mapped:
            {set mappedBodies to mappedBodies + 1}
        |else:
            {if body.bodyType.invariantName != "Star" && 
               (recommendAlreadyMapped || !body.alreadymapped):
                {if reportTerraformables && (body.terraformState.invariantName != "Not terraformable"):
                    {if !toMapList[body.shortname]: 
                        {set toMapList to cat(toMapList, [body.shortname])}
                    } 
                |elif reportPlanetTypes[body.planetClass.invariantName]:
                    {if !toMapList[body.shortname]: 
                        {set toMapList to cat(toMapList, [body.shortname])}
                    }
                |elif body.estimatedvalue > highValueThreshold:
                    {if !toMapList[body.shortname]: 
                        {set toMapList to cat(toMapList, [body.shortname])}
                    } 
                }
            }
        }
    }
}
{set toMapCount to len(toMapList)}

{_ Begin speaking _}

{if toMapCount > 0:

    {if toMapCount = 1: Body |else: Bodies}

    {set cur to 0}
    {while cur < toMapCount:
        {P(toMapList[cur], "body")}
        {set cur to cur + 1}
        {if cur = toMapCount - 1: and
        |elif cur < toMapCount - 1:,
        }
    }

    {if toMapCount = 1: is |else: are }
    {if event.type = "Body mapped": "also" }
    {if toMapCount = 1: a }
    {OneOf("recommended", "good")}
    {set candidates to when(toMapCount = 1, "candidate", "candidates")}
    {OneOf('{candidates} for mapping', '{candidates} to map', 'mapping {candidates}')}.

|elif mappedBodies > 0:

    {OneOf(
        "You have mapped all {if mappedBodies < totalBodies: {OneOf('worthwhile', 'interesting')}} bodies.",
        "All {OneOf( '{if mappedBodies < totalBodies: worthwhile} bodies', 'bodies of interest' )} {OneOf( 'have been mapped.', 'are now mapped.' )}"
    )}
}