Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Dialogue for Planet Description #2633

Closed
johnny2trayz opened this issue Jul 11, 2024 · 9 comments
Closed

Duplicate Dialogue for Planet Description #2633

johnny2trayz opened this issue Jul 11, 2024 · 9 comments
Assignees
Labels
8. annoyance The behaviour is as specified, but has been found to be annoying in practice by real-world users.

Comments

@johnny2trayz
Copy link

johnny2trayz commented Jul 11, 2024

What's Wrong

Duplicate Dialogue for Planet Description

Expected

One description per planet. I understand there is a seperate description for after mapping, but there seems to be a third one that is the same as the first. It is not always an exact duplicate, but it does seem there is a second unnecessary call being done.

Observed

Planet 3 is a notable Water world with terraformable conditions and abundant liquid water.
Mapping is now complete. Efficiency bonus awarded. Planet 3 is a medium-gravity terraformable Water world.
Planet 3 is a notable Water world with potential for terraforming and abundant liquid water.

Planet A 4 is notable, with potential for terraforming.
Mapping is now complete. Efficiency bonus granted. Planet A 4 is a low-gravity terraformable High metal content world.
Planet A 4 is notable, with terraformable conditions.

Steps to reproduce

Scanning worlds.

Configuration

  • Version: 18.07
    • EDDI Version: 4.0.4
    • VoiceAttack Version: N/A
  • Localization
    • EDDI's language: English
    • Voice: IVONA 2 Nicole

My Investigation

Investigation Notes

None

EDDI Logs

https://pastebin.com/fpseS30V

Player journals

https://pastebin.com/qzHaJa7S

@Tkael
Copy link
Member

Tkael commented Jul 12, 2024

Are you using the default personality?
If not, does the problem still occur after you switch to the default personality?
o7

@johnny2trayz
Copy link
Author

I've edited the default personality because of past issues and do not know how to restore it.

@Tkael
Copy link
Member

Tkael commented Jul 12, 2024

First, is the Body mapped script edited? If so, can you share the contents of that script?

image
You should be able to switch to the default personality from the Active personality dropdown on the Speech Responder tab.

@johnny2trayz
Copy link
Author

It is set to default.

{_ Preferences _}

{set bodyReport to 2} {_ 0 = No body report, 1 = Summary body report, 2 = Body report }
{set recommendOtherMapping to 1} {
0 or 1. If 1, recommends other bodies from the Bodies to map script _}

{_ Context}
{SetState('eddi_context_last_action', 'scan')}
{SetState('eddi_context_last_subject', 'body')}
{SetState('eddi_context_body_system', system.name)}
{SetState('eddi_context_body_name', event.name)}
{SetState('eddi_context_last_scan_estimated_value', event.estimatedvalue)}

{_ Process the event _}

{if ship.Role.edname = "Exploration" || ship.Role.edname = "Multipurpose":

{Pause(3000)}

{OneOf("Mapping", "{Occasionally(2, \"Surface\")} Map")}
{OneOf("is", "is now")}
{OneOf("complete", "finished")}.

{if event.probesused <= event.efficiencytarget:
    Efficiency bonus {OneOf("awarded", "granted")}.
}

{Pause(500)}
{if bodyReport = 2:
    {F("Body report")}
|elif bodyReport = 1:
    {F("Body report summary")}
}

{if recommendOtherMapping: 
    {Pause(1500)}
    {F("Bodies to map")}
}

}

@Tkael
Copy link
Member

Tkael commented Jul 13, 2024

Ok. Please confirm if the issue repeats with the default personality?

@johnny2trayz
Copy link
Author

Correct. All default now. No other personalities.

@Tkael
Copy link
Member

Tkael commented Jul 22, 2024

Hi there. Please confirm if this resolved by swapping to the default personality? o7

@johnny2trayz
Copy link
Author

johnny2trayz commented Jul 22, 2024

The issue does not resolve when using default personality, same issue

@Tkael Tkael closed this as completed in ecfdcc9 Jul 29, 2024
@Tkael Tkael self-assigned this Jul 29, 2024
@Tkael Tkael added the 8. annoyance The behaviour is as specified, but has been found to be annoying in practice by real-world users. label Jul 29, 2024
@Tkael
Copy link
Member

Tkael commented Jul 29, 2024

I think I found the issue. Please look to the next release for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8. annoyance The behaviour is as specified, but has been found to be annoying in practice by real-world users.
Projects
None yet
Development

No branches or pull requests

2 participants