Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging on returning errors to uploaders #148

Open
Athanasius opened this issue Oct 26, 2021 · 0 comments
Open

Improve logging on returning errors to uploaders #148

Athanasius opened this issue Oct 26, 2021 · 0 comments

Comments

@Athanasius
Copy link
Contributor

An EDMC 5.2.0 user is seeing.

2021-10-26 20:28:35.675 - WARNING - 8464:8368:8368 plugins.eddn.http_error_to_log:339: Unknown status code from EDDN: None -- <Response [400]>
Exception in Tkinter callback Traceback (most recent call last):
File "C:\Program Files (x86)\EDMarketConnector\plugins\eddn.py", line 289, in sendreplay self.send(cmdr, msg) File "C:\Program Files (x86)\EDMarketConnector\plugins\eddn.py", line 238, in send r.raise_for_status()
File "requests\models.pyc", line 953, in raise_for_status requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://eddn.edcd.io:4430/upload/
During handling of the above exception, another exception occurred:
Traceback (most recent call last): File "tkinter\__init__.pyc", line 1892, in __call__
File "tkinter\__init__.pyc", line 814, in callit
File "C:\Program Files (x86)\EDMarketConnector\plugins\eddn.py", line 307, in sendreplay
status['text'] = self.http_error_to_log(e)
File "C:\Program Files (x86)\EDMarketConnector\plugins\eddn.py", line 341, in http_error_to_log
return _('EDDN Error: Returned {STATUS} status code').format(status_code) KeyError: 'STATUS'

Yes, that log is a little scrambled on line breaks, I did my best to unscramble it. Ref: https://discord.com/channels/164411426939600896/205369618284544000/902622733991542804

This will relate to https://github.com/EDCD/EDDN/blob/master/src/eddn/Gateway.py#L126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant