Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a 'datasource' augmentation for pertinent schemas #157

Open
Athanasius opened this issue Dec 6, 2021 · 0 comments
Open

Consider a 'datasource' augmentation for pertinent schemas #157

Athanasius opened this issue Dec 6, 2021 · 0 comments

Comments

@Athanasius
Copy link
Contributor

Commodites data can come from either CAPI or Journal.

It seems that CAPI /market does not contain any rare commodities, but if a user causes Journal Market.json to be utilised at the same station, and it has a rare commodity for sale, the resulting message will include it. Naively a consumer might think the CAPI data means the rare is no longer available there.

For this, and other reasons, it would be useful for data consumers to know what data source was used to produce a message.

Propose values would be:

  1. journal-pc - From a journal file written directly on a PC running the game client.
  2. journal-capi - From a journal sourced from the CAPI /journal endpoint, which is known to sometimes be problematic.
  3. capi - Data from other CAPI endpoints.

We should perhaps leave things open to list multiple values, but that will complicate things. It would be better to send multiple messages if using data from multiple sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant