Pre-Release 5.0.0-rc1

[Athanasius]

Pre-Release 5.0.0-rc1

Python 3.9

• We now test against, and package with, Python 3.9.5.

  As a consequence of this we no longer support Windows 7. This is due to Python 3.9.x itself not supporting Windows 7. The application (both EDMarketConnector.exe and EDMC.exe) will crash on startup due to a missing DLL.

  This should have no other impact on users or plugin developers, other than the latter now being free to use features that were introduced since the Python 3.7 series.

  Developers can check the contents of the .python-version file in the source (it's not distributed with the Windows installer) for the currently used version in a given branch.

Changes and Enhancements

• If the application detects it's running against a non-live (alpha or beta) version of the game it will append " (beta)" to the Commander name on the main UI.

• Updated translations. Once more, thanks to all the translators!

• We now sanity check a returned Frontier Authentication token to be sure it's for the current Commander. If it's not you'll see Error: customer_id doesn't match! on the bottom status line. Double-check you're using the correct credentials when authing!

• New 'Main window transparency' slider on Settings > Appearance.

• New command-line argument for EDMarketConnector.exe --reset-ui. This will:

  1. Reset to the default Theme.
  2. Reset the UI transparency to fully opaque.

  The intention is this can be used if you've lost sight of the main window due to tweaking these options.

• New CL arg for EDMarketConnector.exe --force-edmc-protocol. This is really only of use to core developers (its purpose being to force use of the edmc:// protocol for Frontier Auth callbacks, even when not 'frozen').

• Linux config will be flushed to disk after any change. This means that EDMC.py can now actually make use of the latest CAPI auth if it's been updated by EDMarketConnector.py since that started.

  If you want to run multiple instances of the application under Linux then please check the updated Troubleshooting: Multi-Accounting wiki entry.

• Linux and macOS: You can now set a font name and size in your config file. Ensuring this is a TTF font, rather than a bitmap font, should allow the application UI scaling to work.

  1. 'font' - the font name to attempt using
  2. 'font_size' - the font size to attempt using.

  There is no UI for this in Preferences, you will need to edit your config file to set or change it, and then restart the application.

  This is not supported on Windows so as not to risk weird bugs. UI Scaling works on Windows without this.

• We now also cite the git 'short hash' in the version string. For a Windows install of the application this is sourced from the .gitversion file (written during the build process).

  When running from source we attempt to use the command git rev-parse --short HEAD to obtain this. If this doesn't work it will be set to 'UNKNOWN'.

• We have added a 'killswitch' feature to turn off specific functionality if it is found to have a bug. An example use of this would be in an "oh shit! we're sending bad data to EDDN!" moment so as to protect EDDN listeners such as EDDB.

  If we ever have to use this we'll announce it clearly and endeavour to get a fixed version of the program released ASAP. We will NOT be using this merely to try and get some laggards to upgrade.

• Our logging code will make best efforts to still show class name and other such fields if it has trouble finding any of the required data for the calling frame. This means no longer seeing ??:??:?? when there is an issue with this.

• macOS: We've managed to test the latest code on macOS Catalina. Other than keyboard shortcut support not working it appears to be working.

• We've pulled the latest Coriolis data which might have caused changes to ship and module names as written out to some files.

Odyssey

Every effort was made during the Odyssey Alphas to ensure that this application will continue to function correctly with it. As always, make a Bug Report if you find anything not working, but be sure to check our Known Issues first.

• A new UI element 'Suit' now appears below 'Ship' when applicable. It details the type of suit you currently have equipped and its Loadout name. This UI element is collapsed/hidden if no suit/on-foot state is detected, e.g. not playing Odyssey.

• Note that we can only reliably know about Suits and their Loadouts from a CAPI data pull (which is what we do automatically on docking if configured to do so, or when you press the 'Update' button). We do attempt to gather this data from Journal events as well, but if you switch to a Suit Loadout that hasn't been mentioned in them yet we won't be able to display that until the next CAPI data pull.

If anyone becomes aware of a 'suit loadouts' site/tool, a la Coriolis/EDSY but for Odyssey Suits, do let us know so we can add support for it! We're already kicking around ideas to e.g. place JSON text in the clipboard if the Suit Loadout is clicked.

Bug Fixes

• Fix ship loadout export to files to not trip up in the face of file encoding issues. This relates to the 'Ship Loadout' option on the 'Output' tab of Settings/Preferences.

• Ship Type/Name will now be greyed out, and not clickable, if we don't currently have loadout information for it. This prevents trying to send an empty loadout to your shipyard provider.

• Bug fixed when handling CAPI-sourced shipyard information. This happens due to a Frontier bug with not returning shipyard data at all for normal stations.

  It has been observed that Frontier has fixed this bug for Odyssey.

• Don't try to get Ship information from LoadGame event if directly in CQC.

• Inara: Don't attempt to send an empty setCommanderReputationMajorFaction API call. This quietens an error from the Inara API caused when a Cmdr literally has no Major Faction Reputation yet.

Code Clean Up

• Code pertaining to processing Journal events was reworked and noisy logging reduced as a consequence.

• A little TRACE logging output has been commented out for now.

• The code for File > Status has been cleaned up.

• Localisation code has been cleaned up.

• Code handling the Frontier Authorisation callback on Windows has been cleaned up.

• A lot of general code cleanup relating to: Inara, outfitting, Frontier CAPI, hotkey (manual Updates), dashboard (Status.json monitoring), commodities files, and ED format ship loadout files.

Plugin Developers

• The files stations.p and systems.p have been removed from the Windows Installer. These were never intended for third-party use. Their use in core code was for generating EDDB-id URLs, but we long since changed the EDDB plugin's handlers for that to use alternate URL formats based on game IDs or names.

  If you were using either to lookup EDDB IDs for systems and/or stations then please see how system_url() and station_url() now work in plugins/eddb.py.

  This change also removed the core (not plugin) eddb.py file which generated these files. You can find it still in the git history if needs be. It had gotten to the stage where generating systems.p took many hours and required 64-bit Python to have any hope of working due to memory usage.

• All static data that is cleared for use by plugins is now in the file edmc_data.py and should be imported from there, not any other module.

  The one thing we didn't move was the 'bracket map' dictionaries in td.py as they're for use only by the code in that file.

  All future such data will be added to this file, and we'll endeavour not to make breaking changes to any of it without increasing our Major version.

• config.appversion() is now a function that returns a semantic_version.Version. In contexts where you're expecting a string this should mostly just work. If needs be wrap it in str().

• Example plugin plugintest updated. This includes an example of how to check core EDMC version if needs be. This example is also in PLUGINS.md.

• config.py has undergone a major rewrite. You should no longer be using config.get(...) or config.getint(...), which will both give a deprecation warning. Use instead the correct config.get_<type>() function:

  • config.get_list(<key>)
  • config.get_str(<key>)
  • config.get_bool(<key>)
  • config.get_int(<key>)

  Setting still uses config.set(...).

• We now change the current working directory of EDMarketConnector.exe to its location as soon as possible in its execution. We're also paranoid about ensuring we reference the full path to the .gitversion file.

  However, no plugin should itself call os.chdir(...) or equivalent. You'll change the current working directory for all core code and other plugins as well (it's global to the whole process, not per-thread). Use full absolute paths instead (pathlib is what to use for this).

• The state dict passed to plugins in journal_entry() calls (which is actually monitor.state in the core code) has received many additions relating to Odyssey, as well as other fixes and enhancements.

  1. Support has been added for the NavRoute (not Route as v28 of the official Journal documentation erroneously labels it) Journal event and its associated file NavRoute.json. See PLUGINS.md:Events documentation

  2. Similarly, there is now support for the ModuleInfo event and its associated ModulesInfo.json file.

  3. state['Credits'] - until now no effort was made to keep this record of the credits balance up to date after the initial LoadGame event. This has now been addressed, and the balance should stay in sync as best it can from the available Journal events. It will always correct back to the actual balance on each CAPI data pull or game relog/restart.

  4. state['Cargo'] now takes account of any CargoTransfer events. This was added to the game in the Fleet Carriers update, but also covers transfers to/from an SRV.

  5. state['OnFoot'] is a new boolean, set true whenever we detect the Cmdr is on-foot, i.e. not in any type of vehicle (Cmdr's own ship, SRV, multi-crew in another Cmdr's ship, Apex taxi, or a Dropship).

  6. state['Suits'] and state['SuitLoadouts'] added as dicts containing information about the Cmdr's owned Suits and the Loadouts the Cmdr has defined to utilise them (and on-foot weapons).
     Note that in the raw CAPI data these are arrays if all members contiguously exist, else a dictionary, but we have chosen to always coerce these to a python dict for simplicity. They will be empty dicts, not None if there is no data.
     We use the CAPI data names for keys, not the Journal ones - e.g. slots for weapons equipped, not Modules.
     The id field found on e.g. weapon details in suit loadouts may be None if we got the data from the Journal rather than the CAPI data.
     NB: This data is only guaranteed up to date and correct after a fresh CAPI data pull, as the current Journal events don't allow for updating it on the fly (this should change in a future Odyssey patch).

  7. state['SuitCurrent'] and state['SuitLoadoutCurrent'] contain the obvious "currently in use" data as per the Suits/SuitLoadouts.

  8. Tracking of the new Odyssey 'Microresources' has been added:

     1. Component - dict for 'Ship Locker' inventory.
     2. Item - dict for 'Ship Locker' inventory.
     3. Consumable - dict for 'Ship Locker' inventory.
     4. Data - dict for 'Ship Locker' inventory.
     5. BackPack - on-foot inventory, a dict containing again dicts for Component, Item, Consumable and Data. However note that the lack of a Journal event when throwing a grenade, along with no BackPackMaterials event if logging in on-foot means that we can't track the BackPack inventory perfectly.

  See the updated PLUGINS.md file for details.

• Note that during the Odyssey Alpha it was observed that the CAPI data['commander']['docked'] boolean was always true if the Cmdr was in their ship. This is a regression from pre-Odyssey behaviour. The core EDMC code copes with this. Please add a reproduction to the issue about this: PTS CAPI saying Commander is Docked after jumping to new system.

---

This discussion was created from the release Pre-Release 5.0.0-rc1.

[Athanasius]

I'd appreciate if any plugin developers who have found this post could sound off, so that I get some idea of how many of you are actually paying attention.

[bgol]

Of course we pay attention ;)
You missed the Flags2 definitions for Odyssey in edmc_data.py:

# Dashboard Flags2 constants
Flags2OnFoot = 1 << 0
Flags2InTaxi = 1 << 1            # (or dropship/shuttle)
Flags2InMulticrew = 1 << 2       # (ie in someone else’s ship)
Flags2OnFootInStation = 1 << 3
Flags2OnFootOnPlanet = 1 << 4
Flags2AimDownSight = 1 << 5
Flags2LowOxygen = 1 << 6
Flags2LowHealth = 1 << 7
Flags2Cold = 1 << 8
Flags2Hot = 1 << 9
Flags2VeryCold = 1 << 10
Flags2VeryHot = 1 << 11

And I just saw that https://github.com/EDCD/EDMarketConnector/blob/main/PLUGINS.md#player-dashboard references import plug for the constants instead of the new one.

[Athanasius]

Do note that it's best to open issues for actual ... issues ... like this.

I did open #1039 already for the first of these though.

[Athanasius]

Both issues now addressed in develop branch.

[aarronc]

Good afternoon,
Commander Psymons and I develop the Hutton Helper plugin. Came across this post so I thought I would say hello and let you know that we are still developing and appreciate all the hard work you put in to make this a great piece of kit to use.

[Athanasius]

I'm doing a quick spot check on another 5.0.0 change.

config.appversion pre-5.0.0 is a simple string.

In 5.0.0 it's now a function returning a semantic_version.Version. That return will mostly work where-ever you need a string, but config.appversion now being a function means that code like:

errorreport['edmcversion'] = appversion

probably won't do what you expect.

[bgol]

I'm doing it like:

from config import appversion
...
    if callable(appversion):
        edmc_version = appversion()
    else:
        edmc_version = appversion

[Athanasius]

Although note we already documented this, to ensure you always have a semantic version:

import semantic_version
from config import appversion

...
    # Up until 5.0.0-beta1 config.appversion is a string
    if isinstance(appversion, str):
        core_version = semantic_version.Version(appversion)

    elif callable(appversion):
        # From 5.0.0-beta1 it's a function, returning semantic_version.Version
        core_version = appversion()

    # Yes, just blow up if config.appverison is neither str or callable

    logger.info(f'Core EDMC version: {core_version}')
    # And then compare like this
    if core_version < semantic_version.Version('5.0.0-beta1'):
        logger.info('EDMC core version is before 5.0.0-beta1')

    else:
        logger.info('EDMC core version is at least 5.0.0-beta1')

[bgol]

import semantic_version is not available on older version of EDMC. It depends on how far back you want to be compatible, I guess.

[Athanasius]

True, but at this stage I think it's MUCH better for plugin developers to help encourage people onto, you know, at least version 4.0.3 4.0.1 or whenever it was we switched to semver. There are bugs galore, including in data sent to EDDN, that we've fixed since then.

[NoFoolLikeOne]

Well, finally got around to updating EDMC-Screenshot

[Athanasius]

Closing this as I'm releasing full 5.0.0 shortly.