-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build both 32-bit and 64-bit installers #1790
Labels
Milestone
Comments
So my other plugins seem to be working ok but PIL has broken on EDMC Screenshot again. It seems it will need to be aware of whether it is 64 bit or 32?
|
Yes, if you want to have a single release that supports both then you'll probably have to just double up the PIL, i.e. import platform
# No, Ath doesn't have the 'match' syntax in his head yet
if platform.architecture()[0] == '64bit':
from Libs.PIL311_64 import Image
...
elif platform.architecture()[0] == '32bit':
from Libs.PIL311 import Image
...
else:
print("Panic!")
... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As we have
develop
working for both 32-bit and 64-bit now it's time to enable building 64-bit on GitHub. However, until 64-bit builds have been more widely tested we will still want to release 32-bit versions as well.x86
to the installer file name.Program Files
, notProgram Files (x86)
. Most likely we'll end up with two skeleton/template files, one for each, or splitting further ?.msi
artifacts, and both should be added to the draft release. Thehashes.sum
should of course cover both.The text was updated successfully, but these errors were encountered: