Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDDN: Journal outfitting schema - check FDevIDs/outfitting.csv SKUs #1797

Open
Athanasius opened this issue Jan 9, 2023 · 0 comments
Open
Labels
bug EDDN unconfirmed An unconfirmed bug

Comments

@Athanasius
Copy link
Contributor

  1. The EDDN docs say "Items that have a non-null "sku" property, unless it's "ELITE_HORIZONS_V_PLANETARY_LANDINGS" (i.e. PowerPlay and tech broker items)." for elisions.
  2. But the current plugins/eddn.py code will only apply that check for CAPI-sourced data, because SKUs aren't cited in Outfitting.json

So, we should probably cross-reference the module name/id with FDevIDs/outfitting.csv to see if that has a SKU cited that means the module should be filtered out in export_journal_outfitting().

@Athanasius Athanasius added bug unconfirmed An unconfirmed bug EDDN labels Jan 9, 2023
@Rixxan Rixxan added this to the Pre-6.0 Changes milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug EDDN unconfirmed An unconfirmed bug
Projects
None yet
Development

No branches or pull requests

2 participants