Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire os.path in favor of pathlib #2114

Closed
Rixxan opened this issue Dec 21, 2023 · 0 comments · Fixed by #2260
Closed

Retire os.path in favor of pathlib #2114

Rixxan opened this issue Dec 21, 2023 · 0 comments · Fixed by #2260
Assignees
@Rixxan
Labels
enhancement Staged Feature Complete and in Testing for Next Release
Milestone
5.12

Comments

@Rixxan
Copy link
Contributor

Rixxan commented Dec 21, 2023

Pathlib and os.path are largely similar, and we use both fluently throughout EDMC.

Pathlib is a newer library since Python 3.4+ (I think).

Since 3.6, pip 519 allows pathlib Paths to be passed as inputs to the functions to os.path. Why keep two different parallel dependencies around?
@Rixxan Rixxan added this to the 6.0.0 milestone Dec 21, 2023
@Rixxan Rixxan modified the milestones: 6.0, Pre-6.0 Changes May 28, 2024
@Michael-K-Williams Michael-K-Williams mentioned this issue Jun 7, 2024
Closed
@Rixxan Rixxan linked a pull request Jun 9, 2024 that will close this issue
Converted all old os.path related library use to Pathlib. 18 files. #2254
Closed
@Rixxan Rixxan modified the milestones: Pre-6.0 Changes, 5.12 Jun 10, 2024
@Rixxan Rixxan mentioned this issue Jun 10, 2024
Merged
@Rixxan Rixxan linked a pull request Jun 16, 2024 that will close this issue
[2114] Pathlib Handover #2260
Merged
@Rixxan Rixxan self-assigned this Jun 16, 2024
@Rixxan Rixxan added the Staged Feature Complete and in Testing for Next Release label Jul 22, 2024
@Rixxan Rixxan closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rixxan Rixxan

Labels
enhancement Staged Feature Complete and in Testing for Next Release
Projects
General Code Cleanups
Status: Done
Milestone
5.12
1 participant
@Rixxan