Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit EDDN Journal vs cAPI Priorities #2156

Open
Rixxan opened this issue Feb 9, 2024 · 0 comments
Open

Revisit EDDN Journal vs cAPI Priorities #2156

Rixxan opened this issue Feb 9, 2024 · 0 comments
Assignees
Milestone

Comments

@Rixxan
Copy link
Contributor

Rixxan commented Feb 9, 2024

Describe the enhancement

Currently, for some EDDN endpoints (particularly commodity), latches exist that would prevent the journal file from being read, and relying instead on cAPI responses alone.

From the Discord:
Given it's the default, most EDMC users will have "Automatically update on docking" active, which means they'll always do a CAPI pull. This means this.commodities will be pre-populated with the data if the player opens the Market screen and causes market.json to be read. If the station market hasn't changed then that check will prevent a market.json-based EDDN message from also being sent.

This is particularly evident in the export_journal_commodities function, which includes some data missing from the cAPI-based response.

This behavior should be revisited to determine if it is how we truly want to do things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant