[2215] Move Logging Directory #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rixxan
added
enhancement
code cleanup
|
Marking as draft until 5.11.2 is out the door. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the default logging directory away from $TEMPDIR or %TEMP% and to the current app data directory (Linux:
~/.local/share/edmarketconnector/logs, Windows:%localappdata%/edmarketconnector/logs).This change is done to better follow the XDG Base Directory specifications, and to unify where files exist to fewer locations. (From up to 3 locations down to 1 for log files, plugin data, and other app files).
Type of Change
Enhancement
How Tested
Tested with various builds and install locations with both installers and user-frozen exe's to ensure logging refers correctly without errors.
Notes
Resolves #2215