Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2262] Generate Inara SLEF #2266

Merged
merged 9 commits into from
Jul 22, 2024

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Jun 23, 2024

Description

This PR adds the ability for users to copy the SLEF representation of their active ship to the clipboard, for export or usage in various other third party tools. Inara's SLEF format is a format of data serving for exporting and importing ship loadouts between apps and sites, based on a principle 'require what is necessary, do not force the rest'. See the Inara SLEF Docs

The PR adds an option to the right-click menu on the "Ship" tab, which is populated whenever a valid loadout is built by the game. The menu is disabled if no SLEF format is found and saved.

Example Images

image

Type of Change

Enhancement

How Tested

Tested under a variety of situations with both complete and incomplete builds to test a SLEF output, tested with various 3rd party SLEF importers such as Spansh's galaxy plotter and EDSY's import functionality.

Notes

Closes #2262

@Rixxan Rixxan added enhancement Inara Ready for Review PRs ready for review and merge labels Jun 23, 2024
@Rixxan Rixxan added this to the 5.12 milestone Jun 23, 2024
@Rixxan Rixxan requested a review from C1701D June 23, 2024 17:29
@Rixxan Rixxan self-assigned this Jun 23, 2024
@Rixxan Rixxan linked an issue Jun 23, 2024 that may be closed by this pull request
@Rixxan Rixxan merged commit 2a9a7f1 into EDCD:develop Jul 22, 2024
3 checks passed
@Rixxan Rixxan deleted the enhancement/2262/generate-inara-slef branch July 22, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Inara Ready for Review PRs ready for review and merge
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Export ship to SLEF option
1 participant