From d08899f1729b2f04ff73d31ebcf35e556ce0828c Mon Sep 17 00:00:00 2001
From: Alexei <alexeiatyahoodotcom@gmail.com>
Date: Mon, 4 Mar 2024 10:55:17 -0500
Subject: [PATCH] Improve tempfile handling

---
 stats.sh | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/stats.sh b/stats.sh
index 6bf3c08..97c5561 100755
--- a/stats.sh
+++ b/stats.sh
@@ -1,18 +1,23 @@
 #!/usr/bin/env bash
 
+tmp_dir=$(mktemp -d "${TMPDIR:-/tmp}/badger_sett_stats.XXXXXXXXX")
+trap 'rm -rf "$tmp_dir"' EXIT
+
 printf "%-11s%-8s%-10s%-24s%-9s%-12s%-14s\n" \
   BROWSER SITES TRACKERS 'ERRORS (TMOs, ANTIBOT)' CRASHES DURATION 'GIT INFO'
 
 for rev in $(git rev-list HEAD -- log.txt); do
-  git --no-pager show "$rev":log.txt > /tmp/log.txt
-  num_domains=$(grep 'domains to crawl' /tmp/log.txt | grep -oP '[0-9,]+')
+  log_txt="$tmp_dir/log.txt"
+  git --no-pager show "$rev":log.txt > "$log_txt"
+  num_domains=$(grep 'domains to crawl' "$log_txt" | grep -oP '[0-9,]+')
+
   printf "%-11s%-8s%-10s%6s%-18s%-9s%-12s%-14s\n" \
-    "$(grep -oP 'browser: [A-Za-z]+' /tmp/log.txt | cut -d ' ' -f 2- | tr '[:upper:]' '[:lower:]')" \
+    "$(grep -oP 'browser: [A-Za-z]+' "$log_txt" | cut -d ' ' -f 2- | tr '[:upper:]' '[:lower:]')" \
     "$num_domains" \
     "$(./validate.py <(git --no-pager show "$rev:results.json") 2>/dev/null | grep 'Newly blocked domains' | grep -oP '[\d]+')" \
-    "$(grep 'errored on' /tmp/log.txt | rev | cut -d ' ' -f -2 | rev | cut -d ' ' -f 2- | sed 's/[()]//g')" \
-    " ($(echo "$(grep -c 'Timed out loading ' /tmp/log.txt) * 100 / $num_domains" | bc -l | xargs printf "%.1f")%, $(echo "$(grep -c 'security page' /tmp/log.txt) * 100 / $num_domains" | bc -l | xargs printf "%.1f")%)" \
-    "$(grep -c 'restarted' /tmp/log.txt)" \
-    "$((($(grep 'Finished scan' /tmp/log.txt | cut -d " " -f "1,2" | xargs -0 date +%s -d) - $(head -n1 /tmp/log.txt | cut -d " " -f "1,2" | xargs -0 date +%s -d)) / 3600)) hours" \
+    "$(grep 'errored on' "$log_txt" | rev | cut -d ' ' -f -2 | rev | cut -d ' ' -f 2- | sed 's/[()]//g')" \
+    " ($(echo "$(grep -c 'Timed out loading ' "$log_txt") * 100 / $num_domains" | bc -l | xargs printf "%.1f")%, $(echo "$(grep -c 'security page' "$log_txt") * 100 / $num_domains" | bc -l | xargs printf "%.1f")%)" \
+    "$(grep -c 'restarted' "$log_txt")" \
+    "$((($(grep 'Finished scan' "$log_txt" | cut -d " " -f "1,2" | xargs -0 date +%s -d) - $(head -n1 "$log_txt" | cut -d " " -f "1,2" | xargs -0 date +%s -d)) / 3600)) hours" \
     "$(git show -s --format="%h  %ci" "$rev")"
 done