Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Badger can break other extensions in Chrome and Edge #2968

Closed
ylluminate opened this issue Jun 1, 2024 · 15 comments
Closed

Privacy Badger can break other extensions in Chrome and Edge #2968

ylluminate opened this issue Jun 1, 2024 · 15 comments

Comments

@ylluminate
Copy link

ylluminate commented Jun 1, 2024

What is your browser and browser version?

What is broken and where?

@ylluminate ylluminate changed the title Privacy Badger breaks Chromium Web Store Latest Privacy Badger update breaks Chromium Web Store Jun 1, 2024
@ghostwords ghostwords changed the title Latest Privacy Badger update breaks Chromium Web Store Chromium Web Store broken in Ungoogled Chromium Jun 1, 2024
@ghostwords
Copy link
Member

Hello and thanks for opening an issue! This may be a problem with extensions that block google.com using Declarative Net Request. I'll reply in the other thread too.

@ghostwords
Copy link
Member

ghostwords commented Jun 1, 2024

Relatedly, I added a Pinterest domain to the yellowlist (0972e2d) to unbreak the Pinterest extension earlier today. So it looks like the Manifest V3 DNR version of Privacy Badger for Chrome can now block (and modify) requests issued by other extensions, whereas I think it couldn't before as a Manifest V2 blockingWebRequest extension.

@ghostwords
Copy link
Member

Having trouble finding the issue that documents DNR having greater scope than webRequest. I did find https://issues.chromium.org/issues/40277172, which seems like a specific example of extensions interfering with one another or even the browser itself through DNR.

@NeverDecaf

This comment was marked as resolved.

@ghostwords
Copy link
Member

Hello! As a workaround, I'll add clients2.google.com to Privacy Badger's yellowlist tomorrow. Once that's done, Privacy Badger will let requests to clients2.google.com through but without access to cookies.

@ghostwords ghostwords added bug Chrome MV3 Manifest V3-specific issue broken extension labels Jun 2, 2024
@ghostwords ghostwords changed the title Chromium Web Store broken in Ungoogled Chromium MV3 DNR Privacy Badger can break other extensions in Chrome Jun 2, 2024
@ghostwords ghostwords pinned this issue Jun 2, 2024
ghostwords added a commit that referenced this issue Jun 2, 2024
@kzar
Copy link

kzar commented Jun 7, 2024

This is an issue with the declarativeNetRequest API at the moment. The Chromium issue is private, but FWIW it's this one: https://issues.chromium.org/issues/40896400. The workaround we went with in the DuckDuckGo Privacy Essentials extension was to not block requests that aren't associated with a tab, to do this we add an allowing session rule that matches tabId -1. See https://github.com/duckduckgo/duckduckgo-privacy-extension/blob/fe067dbf43942752088369963b30de0a530a8b6f/shared/js/background/dnr-service-worker-initiated.js. Hopefully the underlying issue will be resolved soon, I know it's on the extension team's radar.

@ghostwords ghostwords changed the title MV3 DNR Privacy Badger can break other extensions in Chrome MV3 DNR Privacy Badger can break other extensions Jun 8, 2024
@ghostwords ghostwords changed the title MV3 DNR Privacy Badger can break other extensions Privacy Badger can break other extensions in Chrome and Edge Jun 8, 2024
@pixkk
Copy link

pixkk commented Jun 17, 2024

Same problem with extension https://chromewebstore.google.com/detail/chathub-gpt-4-gemini-clau/iaakpnchhognanibcahlpcplchdfmgma - Privacy Badger block request to domains gemini.google.com and copilot.microsoft.com and says, that "There is nothing to do on this page. Privacy Badger doesn't work on pages like this one. Try viewing other pages."

Whitelist not working on extensions page. I need only disable Privacy Badger fully.

Chrome 126.0.6478.62

ghostwords added a commit that referenced this issue Jun 18, 2024
Workaround for #2968

Required by Transover extension, probably others
ghostwords added a commit that referenced this issue Jun 18, 2024
@ghostwords
Copy link
Member

Thanks @pixkk for the report! I just added these two domains to the workaround list. You should get the latest list automatically within the next 24 hours. To force an update in Chrome, visit chrome://extensions, enable "Developer mode", click the "service worker" link in Privacy Badger's listing, select the Console tab, and submit badger.updateYellowlist() into the console. Thanks again!

@pixkk
Copy link

pixkk commented Jun 21, 2024

badger.updateYellowlist()

Thank you! Problem resolved partially.
Without Privacy Badger - "Request is trottled" (IT'S OKAY). With him - websocket closed with reason 1006 (wss://sydney.bing.com/)
image

image

ghostwords added a commit that referenced this issue Jun 21, 2024
@WaqasIbrahim
Copy link

Hello, I am having same issue with a soundcloud downloader extension. Requests to these urls are getting blocked:

https://soundcloud.com/discover
https://api-v2.soundcloud.com

@kzar
Copy link

kzar commented Jun 25, 2024

@ghostwords I worked with some of the Google folks and got a fix for the underlying Chromium issue merged last night. Assuming that sticks, I hope it will be included with Chrome 128 - will keep you posted.

@LilahLys
Copy link

It has been breaking Gumbo: Twitch Companion since yesterday.

@FabrizioMFE
Copy link

It has been breaking Gumbo: Twitch Companion since yesterday.

@LilahLys Found a temporary solution to this, go to Privacy Badger extension options > Tracking Domains > Search for "twitch" enable all and then refresh your [companion Twitch extension] should work with Gumbo and similar, I'm using Twitch Now.

image

@ghostwords
Copy link
Member

This should be fixed in Chrome as of Chrome version 128. Thank you @kzar!

@ghostwords ghostwords unpinned this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants