style: Profile 컴포넌트 UI #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
5 tasks
Open
6 tasks
flowersayo
approved these changes
Jul 20, 2022
|
|
||
| </ProfileBox> | ||
|
|
||
| </> |
There was a problem hiding this comment.
<> </> 부분은 삭제하는 거 어떤가용?!
There was a problem hiding this comment.
헛 필요없겠네요!! 코멘트 감사해요 서연님!!🥰
| height: 575rem; | ||
| background-color: #FFFBF2; | ||
| border-top-left-radius: 30rem; | ||
| border: 1rem solid #D3CEC4; |
There was a problem hiding this comment.
색상부분도 var(-- ) 로 가져다 쓰면 좋을 것 같습니다!
There was a problem hiding this comment.
앗 넵넵! 아무생각없이 만들었네요 하하핳🙈
| * { | ||
| box-sizing: border-box; | ||
| } | ||
|
|
There was a problem hiding this comment.
앗 아녜욥ㅎㅎㅎ 서연님이 저보다 훨씬 더 센스쟁이쥬,,,😎
| 프로필 수정 | ||
| </ProfileEditBtn> | ||
| </BtnBox> | ||
| {/* {showModal && <ProfileEditModal imageInfo={info.image} bioInfo={info.bio} isOpenModal={showModal} setIsOpenModal={setShowModal}/>} */} |
There was a problem hiding this comment.
혹시 이거 react-modal 사용하셔서 구현하신건가용?!
There was a problem hiding this comment.
모달은 아직 만드는 중인데 react-modal은 사용하지 않고 그냥 코드 작성해서 만들고 있어요!(트위터 클론코딩때 썼던 코드 가져와서요ㅎㅎ)
| @@ -1,15 +1,143 @@ | |||
| import React from "react"; | |||
| import React, {useState, useEffect} from 'react'; | |||
| import DefaultImg from "../../assets/DefaultImg.png"; | |||
There was a problem hiding this comment.
저도 이번에 알았는데 png보다 svg 파일로 사용하면 확대했을때 화질이 덜깨지는 것 같더라구용,,,!
피그마에서 svg 형태로도 받을 수 있게끔 되있어서 svg 로 사용해봐도 좋을 듯 합니다😆
There was a problem hiding this comment.
아 그렇군요!! 정보 감사합니다❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profile 컴포넌트 UI 구현
