-
Notifications
You must be signed in to change notification settings - Fork 6
fed: Difference between fdsnws-station text and xml #40
Comments
Is that because the network in the StationXML is being combined to a single entity? It is pretty tricky to combine "identical" networks if their descriptions are even slightly different. |
Hi Gregory, in general However, there is a bug in https://github.com/EIDA/mediatorws/blob/master/eidangservices/federator/server/task.py#L314-L317. It exclusively occurs for I'm going to provide a fix. cheers |
|
Yeah but we should probably agree within EIDA to describe Z3 in am identical way, so for users it becomes clear that it is one network. |
Yeah but we should probably agree within EIDA to describe Z3 in am identical way, so for users it becomes clear that it is one network.
Merging the `NetworkType` element unfortunately is not that trivial.
[StationXML](http://www.fdsn.org/xml/station/fdsn-station-1.0.xsd) even does
not prevent *EIDA* nodes from providing multiple network epochs with the same
`code` attribute but different other `BaseNodeType` attributes (including
additional `NetworkType` and `BaseNodeType` child elements (again see:
http://www.fdsn.org/xml/station/fdsn-station-1.0.xsd)).
IMO merging is no option. Rather, we should implement a solution which is
able to handle multiple `NetworkType` elements (AKA network epochs) including a
proper merging of child elements. Also, this approach prevents us from hiding
data relevant information.
|
- `StationXMLNetworkCombinerTask handles mutliple network epochs i.e. either from a single EIDA node or from multiple EIDA nodes - Since we are merging epochs for `fdsnws-station-xml` we produce automatically inconsitencies when comparing `fdsnws-station?format=xml&level=network` and `fdsnws-station?format=text&level=network`. That is why we should consider implementing `StationTextRequestOrocessor` with merging facilities when used with `level=network` - While merging `<Channel></Channel>` epoch elements they are always appended to already existing `<Station></Station>` epoch elements. Hence, no *real* merging is performed. commit c7fd068edc32985db92955958e34d8ea02c8075b Author: Daniel Armbruster <[email protected]> Date: Tue Jul 31 16:10:54 2018 +0200 fed: remove comment commit 12f21b6bbaafe68fd8df2286c2521113934276b7 Author: Daniel Armbruster <[email protected]> Date: Tue Jul 31 15:57:17 2018 +0200 fed: proceeding: bugfix (#40) - compute sizes correctly commit 52e812949e737d30ea50082e5dc0f39bc30dcb92 Author: Daniel Armbruster <[email protected]> Date: Tue Jul 31 15:20:15 2018 +0200 fed: proceeding: bugfix (#40) - implementation for `fdsnws-station-xml?level=channel` ready commit 788ba112c4188a0ddcd41b1a87768f1c448b98aa Author: Daniel Armbruster <[email protected]> Date: Tue Jul 31 14:24:06 2018 +0200 fed: proceeding: bugfix (#40) - unittests commit f795630f3422263435253c1b06965dcd6e243fa1 Author: Daniel Armbruster <[email protected]> Date: Tue Jul 31 14:22:54 2018 +0200 fed: proceeding: bugfix (#40) - implementation for `fdsnws-station-xml?level=station` working commit fd9ccdcb4dba3e5342bc7300d292e002997c3096 Author: Daniel Armbruster <[email protected]> Date: Mon Jul 30 16:49:48 2018 +0200 fed: proceeding: bugfix (#40) - implementation for `fdsnws-station-xml?level=network` working commit 068fe26320d2166b48573bff59ab956421635121 Author: Daniel Armbruster <[email protected]> Date: Mon Jul 30 15:04:20 2018 +0200 fed: `StationXMLDownloadTask` obsolete.
Pushed new image to DockerHub containing the latest changes from next. Note:
However, it only seems to make a difference when |
@kaestli: |
Continued discussion from
[email protected]
.Dear All,
At RESIF we are testing
eida-federator
, we are doing manual and automatic tests.For our automatic tests we are using one script in Python and we will share it next week. For now it seems working well however we have strange things between
text
format andxml
formatFor example with
net=Z3
eida-federator
provides two different results:Best,
Gregory
The text was updated successfully, but these errors were encountered: