Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ontology issues #98

Open
VladimirAlexiev opened this issue Sep 26, 2024 · 2 comments
Open

ontology issues #98

VladimirAlexiev opened this issue Sep 26, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@VladimirAlexiev
Copy link

Comments based on the diagram in #94 (comment):

  • Why do you need new classes Dataset, Distribution, DataService? You can apply your props to existing classes. IMHO only DataProduct is needed.
    • If it's not the intent to create subclasses, then show the namespace for each class, and do something about the pink "subclass" arrows (maybe make them dashed and without arrowheads)
  • why add rdfs:label? dcat:Resource uses dct:title

More comments:

  • Maybe informationSensitivityClassification should be raised to Resource because Distributions might have different sensitivity?
  • https://ekgf.github.io/dprod/#securityschematype shows Range: dcat:SecuritySchemaType. But there is no such class in dcat, change it to dprod
  • Similar for https://ekgf.github.io/dprod/#protocol: there is no dcat:Protocol
  • dprod:Protocol claims to be "A detailed specification, possibly including a specific version, for how to communicate with a service." but has no properties. Either elaborate or delete this class
@rivettp
Copy link
Contributor

rivettp commented Sep 27, 2024

Need to include info about classes (identifier etc) as we do for properties

@rivettp rivettp added the documentation Improvements or additions to documentation label Sep 27, 2024
@jgeluk
Copy link
Member

jgeluk commented Nov 7, 2024

@rivettp just to clarify/verify, we mean here that we want to show the prefix dcat: in front of class names like @VladimirAlexiev mentioned in his first bullet point right? Because we do not redefine those classes in OWL, they're just referred to from some shapes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants