Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite dissonance indexer. #425

Open
alexandermorgan opened this issue Sep 11, 2016 · 0 comments
Open

Rewrite dissonance indexer. #425

alexandermorgan opened this issue Sep 11, 2016 · 0 comments
Milestone
Release 3.1

Comments

@alexandermorgan
Copy link
Contributor

Some dissonant and non-dissonant notes were correctly labelled in the past, but are now being incorrectly labelled. About 1% of the notes have been affected. This issue crept in somehow when we moved to pandas 0.18.1, which no longer allowed for the forcing of string data type. Sorting out this data type issue was not so difficult, but somehow the accuracy fell a bit. I must admit that the dissonance indexer is rather clunky and in need of a rewrite. I tried to fix this issue and regain our original dissonance detection accuracy but I eventually decided that it was too time consuming of a task. Time on the dissonance indexer would be better spent rewriting it from scratch.
For VIS 3.0, I decided to accept this minor decline in dissonance classification, with the hope of being able to do this rewrite in VIS 3.1 or at least start it.
@alexandermorgan alexandermorgan added this to the Release 3.1 milestone Sep 11, 2016
@alexandermorgan alexandermorgan self-assigned this Sep 11, 2016
alexandermorgan added a commit that referenced this issue Sep 13, 2016
@alexandermorgan
WIP: Improvement in dissonance detection, not finished.
a499f0d 
This is a step in the right direction but still not done. An
_explainable label has been added to distinguish between notes
that have not been analyzed and those that have been deemed the
"consonant" note of a dissonant interval. Related to #425.
@alexandermorgan alexandermorgan removed their assignment Oct 19, 2016
@alexandermorgan alexandermorgan modified the milestones: vis-framework-?.?.?, Release 3.1 Oct 19, 2016
@musicus musicus modified the milestones: Release 3.1, vis-framework-?.?.? May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.1
Development

No branches or pull requests
2 participants
@musicus @alexandermorgan