Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as.peakData() allows tibble inputs which breaks downstream functions (like compound_calcs() ) #10

Open
alecarmstrong opened this issue May 6, 2021 · 0 comments · May be fixed by #14
Open

Comments

@alecarmstrong
Copy link

Hello! I have used your excellent package for exploring my FT-ICR-MS data sets without incident until I inadvertently tried assembling a new peakData object with tibbles instead of strictly using data frames. These were products of some preliminary filtering with dplyr functions and readr::read_table. Then as.peakData seemed happy to accept them as inputs and construct a peakData object. I ran compound_calcs and got an error reading "Error in [<-.data.frame(*tmp*, ai_ids, value = 0) : new columns would leave holes after existing columns". Modifying all the as.peakData inputs with as.data.frame() and rebuilding the peakData object worked fine, but it took a little while to figure out why it suddenly seemed like compound_calcs wasn't working. Thought you might be interested in case anyone else runs into this! Here's a quick console screenshot in case that helps illustrate.
ftmsRanalysis_issue_console_screenshot

@Natalie-Winans Natalie-Winans linked a pull request Jul 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant