Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for layernorm #126

Closed
jonas-doevenspeck opened this issue Jan 31, 2023 · 6 comments
Closed

support for layernorm #126

jonas-doevenspeck opened this issue Jan 31, 2023 · 6 comments
Assignees
@senysenyseny16
Labels
feat new feature for the user

Comments

@jonas-doevenspeck
Copy link

jonas-doevenspeck commented Jan 31, 2023 •
edited
Loading

Are there any plans to support LayerNorm?
It's available in onnx-opset 17 which can be exported to from torch>=1.13
It's commonly used in transformers so would be very useful!
@senysenyseny16
Copy link
Collaborator

Hello, @jonas-doevenspeck

Since PyTorch has LayerNorm module this shouldn't be hard.

I think we will add support soon.

@senysenyseny16 senysenyseny16 added the feat new feature for the user label Feb 4, 2023
@JohnMasoner
Copy link
Contributor

#143

@senysenyseny16 senysenyseny16 mentioned this issue Feb 27, 2023
Closed
@github-actions github-actions bot added Stale and removed Stale labels Mar 27, 2023
@github-actions github-actions bot added the Stale label Apr 30, 2023
@ENOT-AutoDL ENOT-AutoDL deleted a comment from github-actions bot May 13, 2023
@ENOT-AutoDL ENOT-AutoDL deleted a comment from github-actions bot May 13, 2023
@ENOT-AutoDL ENOT-AutoDL deleted a comment from github-actions bot May 13, 2023
@upskyy
Copy link

upskyy commented Jun 7, 2023

@senysenyseny16 I am also trying to convert a model with onnx-opset 17 to a torch. Is LayerNorm supported?
Do you have any updates?

@senysenyseny16
Copy link
Collaborator

senysenyseny16 commented Jul 5, 2023 •
edited
Loading

hi @upskyy updated PR: #165, i think it will be merged in coming days after @ivkalgin review.

@senysenyseny16 senysenyseny16 self-assigned this Jul 5, 2023
@senysenyseny16
Copy link
Collaborator

@JohnMasoner @jonas-doevenspeck @upskyy

released: https://github.com/ENOT-AutoDL/onnx2torch/releases/tag/v1.5.9

@senysenyseny16
Copy link
Collaborator

Feel free to reopen if there are any problems or questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senysenyseny16 senysenyseny16

Labels
feat new feature for the user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JohnMasoner @upskyy @senysenyseny16 @jonas-doevenspeck