Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Postcard as an encoding format #19

Closed
Firaenix opened this issue Jul 11, 2024 · 4 comments
Closed

Support for Postcard as an encoding format #19

Firaenix opened this issue Jul 11, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Firaenix
Copy link
Contributor

Hi,

I love your library! I've used it myself to build a distributed database and its worked so well for me in the past.
However, I've been playing around a lot with https://github.com/jamesmunns/postcard and have had a lot of success with it in regards to size & performance and was wondering what the best way would be to use this with Remoc?

@surban
Copy link
Member

surban commented Jul 11, 2024

Great, that remoc is useful to you!

Since Postcard is a serde codec, it should be straightforward to add it to the supported codecs and add the necessary features to Cargo.toml.

Could you send a PR, if possible?

@surban surban self-assigned this Jul 11, 2024
@surban surban added the enhancement New feature or request label Jul 11, 2024
@Firaenix
Copy link
Contributor Author

Yep that should be possible, I'll put aside some time tomorrow to create the PR

@Firaenix
Copy link
Contributor Author

Hi,

I've completed the PR here: #20

@surban
Copy link
Member

surban commented Jul 14, 2024

Fixed in #20

@surban surban closed this as completed Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants